From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Max Filippov <jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-xtensa-PjhNF2WwrV/0Sa2dR60CXw@public.gmane.org"
<linux-xtensa-PjhNF2WwrV/0Sa2dR60CXw@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Chris Zankel <chris-YvXeqwSYzG2sTnJN9+BGXg@public.gmane.org>,
Marc Gauthier <marc-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH 1/3] spi: add xtfpga SPI controller driver
Date: Wed, 12 Mar 2014 13:24:27 +0000 [thread overview]
Message-ID: <20140312132427.GR28112@sirena.org.uk> (raw)
In-Reply-To: <CAMo8BfKFp1kz8S_4JbSh5=f+hMygJL1670fkFfzdArgDqtW72A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
On Wed, Mar 12, 2014 at 05:48:16AM +0400, Max Filippov wrote:
> On Wed, Mar 12, 2014 at 5:11 AM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > So I just looked again - the SPI code isn't in mainline, there must
> > be some out of tree patches here that can't have been tested since the
> > driver was converted to regmap (or the byte swapping you're doing in the
> > controller is buggy for 16 bits per word).
> I'm successfully running this driver with the patches in your ASoC tree
> branch topic/tlv320aic23.
Ah, I missed that during review - the driver shouldn't be forcing 16
bits per word, any swapping that's needed should be being done in the
regmap API. Though based on the discussion of the SPI driver it seems
like this may be compensating for an unwanted byte swap there.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-12 13:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 12:44 [PATCH 0/3] xtensa xtfpga SPI controller driver Max Filippov
2014-03-11 12:44 ` [PATCH 2/3] spi/xtensa-xtfpga: add DT binding documentation Max Filippov
[not found] ` <1394541891-26469-1-git-send-email-jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-11 12:44 ` [PATCH 1/3] spi: add xtfpga SPI controller driver Max Filippov
[not found] ` <1394541891-26469-2-git-send-email-jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-11 19:49 ` Mark Brown
2014-03-11 20:20 ` Max Filippov
[not found] ` <CAMo8BfLTn+pneF6_7XkP66+LzpZgcefnAo_FkwxpvtYdt9yduA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-12 0:34 ` Mark Brown
[not found] ` <20140312003401.GE28112-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-12 0:59 ` Max Filippov
[not found] ` <CAMo8Bf+dePYf0jW6zaH-4Qiy5oF-bBzHjkfzL1u6pyTS1OE46w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-12 1:08 ` Mark Brown
[not found] ` <20140312010858.GI28112-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-12 1:43 ` Max Filippov
[not found] ` <CAMo8BfL6dwgZitRBZQEU6HCRVMRoYhPkiJWW5QTpS-cu-njR5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-12 1:53 ` Mark Brown
2014-03-12 1:11 ` Mark Brown
2014-03-12 1:48 ` Max Filippov
[not found] ` <CAMo8BfKFp1kz8S_4JbSh5=f+hMygJL1670fkFfzdArgDqtW72A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-12 13:24 ` Mark Brown [this message]
2014-03-11 12:44 ` [PATCH 3/3] MAINTAINERS: add xtfpga platform section Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312132427.GR28112@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=chris-YvXeqwSYzG2sTnJN9+BGXg@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-xtensa-PjhNF2WwrV/0Sa2dR60CXw@public.gmane.org \
--cc=marc-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).