From: Mark Brown <broonie@kernel.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, peter.ujfalusi@ti.com,
liam.r.girdwood@linux.intel.com, bcousson@baylibre.com,
detheridge@ti.com
Subject: Re: [PATCH v5] ASoC: tlv320aic31xx: Add basic codec driver implementation
Date: Thu, 13 Mar 2014 12:20:07 +0000 [thread overview]
Message-ID: <20140313122007.GQ366@sirena.org.uk> (raw)
In-Reply-To: <1394535452-17865-1-git-send-email-jsarha@ti.com>
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
On Tue, Mar 11, 2014 at 12:57:32PM +0200, Jyri Sarha wrote:
> This commit adds a bare bones driver support for TLV320AIC31XX family
> audio codecs. The driver adds basic stereo playback trough headphone
> and speaker outputs and mono capture trough microphone inputs.
Applied, thanks. One thing it'd be good to fix:
> +Optional properties:
> +
> +- gpio-reset - gpio pin number used for codec reset
> +- ai31xx-micbias-vg - MicBias Voltage setting
This is optional but...
> + of_property_read_u32(np, "ai31xx-micbias-vg", &value);
> + switch (value) {
> + case MICBIAS_2_0V:
> + case MICBIAS_2_5V:
> + case MICBIAS_AVDDV:
> + aic31xx->pdata.micbias_vg = value;
> + break;
> + default:
> + dev_err(aic31xx->dev,
> + "Bad ai31xx-micbias-vg value %d DT\n",
> + value);
> + aic31xx->pdata.micbias_vg = MICBIAS_2_0V;
> + }
...you'll get an error if it's missing (and an uninitialised memory
read).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-13 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 10:57 [PATCH v5] ASoC: tlv320aic31xx: Add basic codec driver implementation Jyri Sarha
2014-03-13 12:20 ` Mark Brown [this message]
2014-03-13 15:30 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313122007.GQ366@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=detheridge@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).