devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: bcm28155-ap: leave camldo1 on to fix reboot
@ 2014-03-12 13:14 Matt Porter
  2014-03-12 13:16 ` Alex Elder
  2014-03-14 16:55 ` Matt Porter
  0 siblings, 2 replies; 3+ messages in thread
From: Matt Porter @ 2014-03-12 13:14 UTC (permalink / raw)
  To: Alex Elder, Linux ARM Kernel List
  Cc: Mark Brown, Christian Daudt, Devicetree List,
	bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w,
	Linux Kernel Mailing List

The BCM28155-AP board has a bootloader that expects the camldo1
regulator to be enabled on entry. Currently, the camldo1 regulator
is disabled when no longer in use as is the case during a reboot /
warm reset. This causes the early bootloader to hang upon entry. Add
regulator-always-on to the camldo1 constraint to fix reboot.

Reported-by: Alex Elder <elder-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Signed-off-by: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
[Depends on BCM59056 regulator series dts support:
 http://www.gossamer-threads.com/lists/linux/kernel/1885489]

 arch/arm/boot/dts/bcm28155-ap.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
index 99ff0c1..cc1303c 100644
--- a/arch/arm/boot/dts/bcm28155-ap.dts
+++ b/arch/arm/boot/dts/bcm28155-ap.dts
@@ -94,6 +94,7 @@
 		camldo1_reg: camldo1 {
 			regulator-min-microvolt = <3300000>;
 			regulator-max-microvolt = <3300000>;
+			regulator-always-on;
 		};
 
 		sdldo_reg: sdldo {
-- 
1.8.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: bcm28155-ap: leave camldo1 on to fix reboot
  2014-03-12 13:14 [PATCH] ARM: dts: bcm28155-ap: leave camldo1 on to fix reboot Matt Porter
@ 2014-03-12 13:16 ` Alex Elder
  2014-03-14 16:55 ` Matt Porter
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Elder @ 2014-03-12 13:16 UTC (permalink / raw)
  To: Matt Porter, Alex Elder, Linux ARM Kernel List
  Cc: Mark Brown, Christian Daudt, Devicetree List,
	bcm-kernel-feedback-list, Linux Kernel Mailing List

On 03/12/2014 08:14 AM, Matt Porter wrote:
> The BCM28155-AP board has a bootloader that expects the camldo1
> regulator to be enabled on entry. Currently, the camldo1 regulator
> is disabled when no longer in use as is the case during a reboot /
> warm reset. This causes the early bootloader to hang upon entry. Add
> regulator-always-on to the camldo1 constraint to fix reboot.
> 
> Reported-by: Alex Elder <elder@linaro.org>
> Signed-off-by: Matt Porter <mporter@linaro.org>

Tested-by: Alex Elder <elder@linaro.org>

> ---
> [Depends on BCM59056 regulator series dts support:
>  http://www.gossamer-threads.com/lists/linux/kernel/1885489]
> 
>  arch/arm/boot/dts/bcm28155-ap.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
> index 99ff0c1..cc1303c 100644
> --- a/arch/arm/boot/dts/bcm28155-ap.dts
> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
> @@ -94,6 +94,7 @@
>  		camldo1_reg: camldo1 {
>  			regulator-min-microvolt = <3300000>;
>  			regulator-max-microvolt = <3300000>;
> +			regulator-always-on;
>  		};
>  
>  		sdldo_reg: sdldo {
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: bcm28155-ap: leave camldo1 on to fix reboot
  2014-03-12 13:14 [PATCH] ARM: dts: bcm28155-ap: leave camldo1 on to fix reboot Matt Porter
  2014-03-12 13:16 ` Alex Elder
@ 2014-03-14 16:55 ` Matt Porter
  1 sibling, 0 replies; 3+ messages in thread
From: Matt Porter @ 2014-03-14 16:55 UTC (permalink / raw)
  To: Alex Elder, Linux ARM Kernel List
  Cc: Mark Brown, Christian Daudt, Devicetree List,
	bcm-kernel-feedback-list, Linux Kernel Mailing List

On Wed, Mar 12, 2014 at 09:14:39AM -0400, Matt Porter wrote:
> The BCM28155-AP board has a bootloader that expects the camldo1
> regulator to be enabled on entry. Currently, the camldo1 regulator
> is disabled when no longer in use as is the case during a reboot /
> warm reset. This causes the early bootloader to hang upon entry. Add
> regulator-always-on to the camldo1 constraint to fix reboot.
> 
> Reported-by: Alex Elder <elder@linaro.org>
> Signed-off-by: Matt Porter <mporter@linaro.org>
> ---
> [Depends on BCM59056 regulator series dts support:
>  http://www.gossamer-threads.com/lists/linux/kernel/1885489]

Applied to mach-bcm armsoc/for-3.15/dt

-Matt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-03-14 16:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-12 13:14 [PATCH] ARM: dts: bcm28155-ap: leave camldo1 on to fix reboot Matt Porter
2014-03-12 13:16 ` Alex Elder
2014-03-14 16:55 ` Matt Porter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).