[PATCH v11 01/27] iommu/exynos: do not include removed header

public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH v11 01/27] iommu/exynos: do not include removed header
@ 2014-03-14  5:01 Cho KyongHo
       [not found] ` <20140314140129.68a41cc1bd9e0a48a198ca13-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Cho KyongHo @ 2014-03-14  5:01 UTC (permalink / raw)
  To: Linux ARM Kernel, Linux DeviceTree, Linux IOMMU, Linux Kernel,
	Linux Samsung SOC
  Cc: Kukjin Kim, Prathyush, Grant Grundler, Sachin Kamat,
	Sylwester Nawrocki, Varun Sethi, Antonios Motakis, Tomasz Figa,
	Rahul Sharma

Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
removing remaining use of it from exynos-iommu driver, thus causing a
compilation error.

This patch fixes the error by removing respective include line
from exynos-iommu.c.

CC: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/iommu/exynos-iommu.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 0740189..4876d35 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -12,6 +12,7 @@
 #define DEBUG
 #endif
 
+#include <linux/kernel.h>
 #include <linux/io.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
@@ -29,8 +30,6 @@
 #include <asm/cacheflush.h>
 #include <asm/pgtable.h>
 
-#include <mach/sysmmu.h>
-
 /* We does not consider super section mapping (16MB) */
 #define SECT_ORDER 20
 #define LPAGE_ORDER 16
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread

[parent not found: <20140314140129.68a41cc1bd9e0a48a198ca13-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]

* Re: [PATCH v11 01/27] iommu/exynos: do not include removed header
       [not found] ` <20140314140129.68a41cc1bd9e0a48a198ca13-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2014-03-14  9:59   ` Sachin Kamat
       [not found]     ` <CAK9yfHzRasE3jroDUZgAa=DN5N=2ZDAxgNiHDCip+f2868BAVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2014-03-14  9:59 UTC (permalink / raw)
  To: Cho KyongHo
  Cc: Linux DeviceTree, Linux Samsung SOC, Prathyush, Grant Grundler,
	Linux Kernel, Linux IOMMU, Kukjin Kim, Sylwester Nawrocki,
	Varun Sethi, Antonios Motakis, Tomasz Figa, Linux ARM Kernel,
	Rahul Sharma

On 14 March 2014 10:31, Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
> exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
> removing remaining use of it from exynos-iommu driver, thus causing a
> compilation error.
>
> This patch fixes the error by removing respective include line
> from exynos-iommu.c.
>
> CC: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/iommu/exynos-iommu.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> index 0740189..4876d35 100644
> --- a/drivers/iommu/exynos-iommu.c
> +++ b/drivers/iommu/exynos-iommu.c
> @@ -12,6 +12,7 @@
>  #define DEBUG
>  #endif
>
> +#include <linux/kernel.h>

This change doesn't look related to the patch subject/description.

-- 
With warm regards,
Sachin

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <CAK9yfHzRasE3jroDUZgAa=DN5N=2ZDAxgNiHDCip+f2868BAVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]

* RE: [PATCH v11 01/27] iommu/exynos: do not include removed header
       [not found]     ` <CAK9yfHzRasE3jroDUZgAa=DN5N=2ZDAxgNiHDCip+f2868BAVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-03-14 11:49       ` Cho KyongHo
  2014-03-14 11:59         ` Sachin Kamat
  0 siblings, 1 reply; 5+ messages in thread
From: Cho KyongHo @ 2014-03-14 11:49 UTC (permalink / raw)
  To: 'Sachin Kamat'
  Cc: 'Linux DeviceTree', 'Linux Samsung SOC',
	'Prathyush', 'Grant Grundler',
	'Linux Kernel', 'Linux IOMMU',
	'Kukjin Kim', 'Sylwester Nawrocki',
	'Varun Sethi', 'Antonios Motakis',
	'Tomasz Figa', 'Linux ARM Kernel',
	'Rahul Sharma'

> From: Sachin Kamat [mailto:sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org]
> Sent: Friday, March 14, 2014 7:00 PM
> 
> On 14 March 2014 10:31, Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
> > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
> > removing remaining use of it from exynos-iommu driver, thus causing a
> > compilation error.
> >
> > This patch fixes the error by removing respective include line
> > from exynos-iommu.c.
> >
> > CC: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > Signed-off-by: Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > ---
> >  drivers/iommu/exynos-iommu.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> > index 0740189..4876d35 100644
> > --- a/drivers/iommu/exynos-iommu.c
> > +++ b/drivers/iommu/exynos-iommu.c
> > @@ -12,6 +12,7 @@
> >  #define DEBUG
> >  #endif
> >
> > +#include <linux/kernel.h>
> 
> This change doesn't look related to the patch subject/description.
> 
Yes. But it is simply added without any side-effect.
Do you think it should be in a separate patch?.
Actually, the added line is a redundant.

Regards,

KyongHo.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v11 01/27] iommu/exynos: do not include removed header
  2014-03-14 11:49       ` Cho KyongHo
@ 2014-03-14 11:59         ` Sachin Kamat
       [not found]           ` <CAK9yfHyGfdP+0RKtdSCdU4tO=PX8GbQRQ7ar=ST5B2RenZMMsg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2014-03-14 11:59 UTC (permalink / raw)
  To: Cho KyongHo
  Cc: Linux DeviceTree, Linux Samsung SOC, Prathyush, Grant Grundler,
	Linux Kernel, Linux IOMMU, Kukjin Kim, Sylwester Nawrocki,
	Varun Sethi, Antonios Motakis, Tomasz Figa, Linux ARM Kernel,
	Rahul Sharma

On 14 March 2014 17:19, Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>> From: Sachin Kamat [mailto:sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org]
>> Sent: Friday, March 14, 2014 7:00 PM
>>
>> On 14 March 2014 10:31, Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
>> > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
>> > removing remaining use of it from exynos-iommu driver, thus causing a
>> > compilation error.
>> >
>> > This patch fixes the error by removing respective include line
>> > from exynos-iommu.c.
>> >
>> > CC: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> > Signed-off-by: Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> > ---
>> >  drivers/iommu/exynos-iommu.c |    3 +--
>> >  1 file changed, 1 insertion(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
>> > index 0740189..4876d35 100644
>> > --- a/drivers/iommu/exynos-iommu.c
>> > +++ b/drivers/iommu/exynos-iommu.c
>> > @@ -12,6 +12,7 @@
>> >  #define DEBUG
>> >  #endif
>> >
>> > +#include <linux/kernel.h>
>>
>> This change doesn't look related to the patch subject/description.
>>
> Yes. But it is simply added without any side-effect.
> Do you think it should be in a separate patch?.
> Actually, the added line is a redundant.

If it is redundant, then you shouldn't be adding it. If it is
required, then please
mention about the need in the commit description if not a separate patch.

-- 
With warm regards,
Sachin

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <CAK9yfHyGfdP+0RKtdSCdU4tO=PX8GbQRQ7ar=ST5B2RenZMMsg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]

* Re: [PATCH v11 01/27] iommu/exynos: do not include removed header
       [not found]           ` <CAK9yfHyGfdP+0RKtdSCdU4tO=PX8GbQRQ7ar=ST5B2RenZMMsg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-03-17  0:26             ` Cho KyongHo
  0 siblings, 0 replies; 5+ messages in thread
From: Cho KyongHo @ 2014-03-17  0:26 UTC (permalink / raw)
  To: Sachin Kamat
  Cc: Linux DeviceTree, Linux Samsung SOC, Prathyush, Grant Grundler,
	Linux Kernel, Linux IOMMU, Kukjin Kim, Sylwester Nawrocki,
	Varun Sethi, Antonios Motakis, Tomasz Figa, Linux ARM Kernel,
	Rahul Sharma

On Fri, 14 Mar 2014 17:29:36 +0530, Sachin Kamat wrote:
> On 14 March 2014 17:19, Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> >> From: Sachin Kamat [mailto:sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org]
> >> Sent: Friday, March 14, 2014 7:00 PM
> >>
> >> On 14 March 2014 10:31, Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> >> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
> >> > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
> >> > removing remaining use of it from exynos-iommu driver, thus causing a
> >> > compilation error.
> >> >
> >> > This patch fixes the error by removing respective include line
> >> > from exynos-iommu.c.
> >> >
> >> > CC: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> >> > Signed-off-by: Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> >> > ---
> >> >  drivers/iommu/exynos-iommu.c |    3 +--
> >> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >> >
> >> > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> >> > index 0740189..4876d35 100644
> >> > --- a/drivers/iommu/exynos-iommu.c
> >> > +++ b/drivers/iommu/exynos-iommu.c
> >> > @@ -12,6 +12,7 @@
> >> >  #define DEBUG
> >> >  #endif
> >> >
> >> > +#include <linux/kernel.h>
> >>
> >> This change doesn't look related to the patch subject/description.
> >>
> > Yes. But it is simply added without any side-effect.
> > Do you think it should be in a separate patch?.
> > Actually, the added line is a redundant.
> 
> If it is redundant, then you shouldn't be adding it. If it is
> required, then please
> mention about the need in the commit description if not a separate patch.
> 

Ok.

Thanks for the advice.

KyongHo

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-03-17  0:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-14  5:01 [PATCH v11 01/27] iommu/exynos: do not include removed header Cho KyongHo
     [not found] ` <20140314140129.68a41cc1bd9e0a48a198ca13-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-14  9:59   ` Sachin Kamat
     [not found]     ` <CAK9yfHzRasE3jroDUZgAa=DN5N=2ZDAxgNiHDCip+f2868BAVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-14 11:49       ` Cho KyongHo
2014-03-14 11:59         ` Sachin Kamat
     [not found]           ` <CAK9yfHyGfdP+0RKtdSCdU4tO=PX8GbQRQ7ar=ST5B2RenZMMsg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-17  0:26             ` Cho KyongHo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox