Re: [PATCH v6 2/3] ARM: sun7i/sun6i: dts: Add NMI irqchip support

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

On Sat, Mar 15, 2014 at 02:41:00PM +0100, Carlo Caione wrote:
> This patch adds DTS entries for NMI controller as child of GIC.
> 
> Signed-off-by: Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
> ---
>  arch/arm/boot/dts/sun6i-a31.dtsi | 9 +++++++++
>  arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
> index 5256ad9..4a5050c 100644
> --- a/arch/arm/boot/dts/sun6i-a31.dtsi
> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi
> @@ -190,6 +190,15 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> +		nmi_intc: sc-nmi-intc@01f00c0c {

It should be interrupt-controller@01f00c0c, according to the ePAPR.

> +			compatible = "allwinner,sun6i-a31-sc-nmi";

I'm curious, what is the "sc" for?

> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			reg = <0x01f00c0c 0x38>;
> +			interrupt-parent = <&gic>;

This is actually the default.

> +			interrupts = <0 0 4>;
> +		};
> +

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]