devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 3/5] net: cpsw: Add control-module macid driver
Date: Mon, 17 Mar 2014 10:11:36 -0700	[thread overview]
Message-ID: <20140317171136.GC30471@atomide.com> (raw)
In-Reply-To: <1394888864-11007-4-git-send-email-mpa@pengutronix.de>

Hi,

* Markus Pargmann <mpa@pengutronix.de> [140315 06:12]:
> This driver extracts the hardware macid from the control module of
> am335x processors. It exports a function cpsw_ctrl_macid_read for cpsw
> to get the macid from within the processor.

Few things have improved recently :) This can be now implemented
in a much cleaner way using regmap against the already defined syscon
node.

For an example, see how the MMC PBIAS regulator is using regmap
in Linux next:

11469e0bb1 (regulator: add pbias regulator support)
cd042fe5c1 (ARM: dts: add pbias dt node)

That avoids the problem of the tinkering with SoC specific registers
that belong to another device.

So please update this series for regmap, let's not add more mapping
of system control module registers to the drivers.

Regards,

Tony

  parent reply	other threads:[~2014-03-17 17:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-15 13:07 [PATCH v2 0/5] net: cpsw: Support for am335x chip MACIDs Markus Pargmann
2014-03-15 13:07 ` [PATCH v2 1/5] net: cpsw: document mac-address being optional Markus Pargmann
2014-03-15 13:07 ` [PATCH v2 2/5] net: cpsw: make cpsw.h self-contained Markus Pargmann
2014-03-15 13:07 ` [PATCH v2 3/5] net: cpsw: Add control-module macid driver Markus Pargmann
2014-03-17  9:05   ` Uwe Kleine-König
2014-03-18  8:06     ` Markus Pargmann
2014-03-17 17:11   ` Tony Lindgren [this message]
2014-03-18  8:04     ` Markus Pargmann
2014-03-15 13:07 ` [PATCH v2 4/5] net: cpsw: Use cpsw-ctrl-macid driver Markus Pargmann
2014-03-15 13:07 ` [PATCH v2 5/5] arm: dts: am33xx, Add device node for cpsw-ctrl-macid Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140317171136.GC30471@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).