From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v4 0/9] Watchdog support for Armada 375/38x SoC Date: Mon, 17 Mar 2014 17:47:06 -0300 Message-ID: <20140317204706.GB1118@arch.cereza> References: <1394907484-26002-1-git-send-email-ezequiel.garcia@free-electrons.com> <532748C2.9030009@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <532748C2.9030009-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sebastian Hesselbarth Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jason Cooper , Wim Van Sebroeck , Guenter Roeck , Jason Gunthorpe , Andrew Lunn , Thomas Petazzoni , Gregory Clement , Lior Amsalem , Tawfik Bayouk List-Id: devicetree@vger.kernel.org On Mar 17, Sebastian Hesselbarth wrote: > On 03/15/2014 07:17 PM, Ezequiel Garcia wrote: > >Fourth round of the patchset adding support for watchdog on Armada 3= 75 and > >Armada 38x SoCs. > > > >The new Armada 375/385 SoCs have two registers for the watchdog RSTO= UT: > > > > 1. It has a dedicated register (similar to the one in A370/XP) > > 2. Also has a bit in a shared RSTOUT register. > > > >Therefore, in order to support this two-folded RSTOUT, we extend the= 'reg' > >property in the watchdog devicetree and require a new pair of cells = to specify > >the shared RSTOUT. > > > >On the driver side, we need to implement per-SoC stop() and enabled(= ) > >functions. Such somewhat complex infrastructure is needed to ensure = the driver > >performs proper reset of the watchdog timer, by masking and disablin= g the > >RSTOUT before the interrupt is enabled. > > > >I've pushed a branch so people can test this easily, e.g. ensuring > >no regressions on Dove, Kirkwood and A370/XP: >=20 > Ezequiel, >=20 > Although, I just saw below that you actually already tested on Dove, > you can add my >=20 > Tested-by: Sebastian Hesselbarth >=20 Great, thanks! --=20 Ezequiel Garc=EDa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html