From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [PATCH v5 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller Date: Thu, 20 Mar 2014 00:04:37 -0500 Message-ID: <20140320050437.GA29449@qualcomm.com> References: <1394762863-12154-1-git-send-email-bjorn.andersson@sonymobile.com> <1394762863-12154-3-git-send-email-bjorn.andersson@sonymobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1394762863-12154-3-git-send-email-bjorn.andersson@sonymobile.com> Sender: linux-doc-owner@vger.kernel.org To: Bjorn Andersson Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Rob Landley , Wolfram Sang , Grant Likely , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd , "Ivan T. Ivanov" List-Id: devicetree@vger.kernel.org On Thu, Mar 13, 2014 at 07:07:43PM -0700, Bjorn Andersson wrote: > This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. > The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path > engine with input/output FIFOs and an embedded i2c mini-core. The driver > supports FIFO mode (for low bandwidth applications) and block mode (interrupt > generated for each block-size data transfer). > Looks good. Reviewed-by: Andy Gross -- sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation