From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCHv4 2/5] Input: edt-ft5x06: Add DT support Date: Thu, 20 Mar 2014 12:40:55 +0100 Message-ID: <20140320124055.53d469e7@ipc1.ka-ro> References: <1395234563-11034-1-git-send-email-LW@KARO-electronics.de> <1395234563-11034-3-git-send-email-LW@KARO-electronics.de> <20140320093719.GB14420@e106331-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20140320093719.GB14420@e106331-lin.cambridge.arm.com> Sender: linux-doc-owner@vger.kernel.org To: Mark Rutland Cc: Dmitry Torokhov , Fugang Duan , "grant.likely@linaro.org" , Henrik Rydberg , Ian Campbell , Jingoo Han , Kumar Gala , Pawel Moll , Rob Herring , Rob Landley , Sachin Kamat , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Simon Budig List-Id: devicetree@vger.kernel.org Hi, Mark Rutland wrote: > On Wed, Mar 19, 2014 at 01:09:20PM +0000, Lothar Wa=C3=9Fmann wrote: > >=20 > > Signed-off-by: Lothar Wa=C3=9Fmann > > --- > > .../bindings/input/touchscreen/edt-ft5x06.txt | 41 ++++++ > > drivers/input/touchscreen/edt-ft5x06.c | 144 ++++++++= +++++++----- > > 2 files changed, 154 insertions(+), 31 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/input/touchsc= reen/edt-ft5x06.txt > >=20 > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/ed= t-ft5x06.txt b/Documentation/devicetree/bindings/input/touchscreen/edt-= ft5x06.txt > > new file mode 100644 > > index 0000000..e5adc76 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x0= 6.txt > > @@ -0,0 +1,41 @@ > > +FocalTech EDT-FT5x06 Polytouch driver > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + > > +Required properties: > > + - compatible: "edt,edt-ft5x06" >=20 > Is the 'x' part of a particular product name, or is this a class of > devices? >=20 The FT5x06 datasheet lists 3 variants for different panel sizes. I'll add distinct compatible strings for those chips, though their SW interface is (currently) identical: |Required properties: | - compatible: "edt,edt-ft5206", "edt,edt-ft5x06" | or: "edt,edt-ft5306", "edt,edt-ft5x06" | or: "edt,edt-ft5406", "edt,edt-ft5x06" > > + - reg: I2C slave address of the chip (0x38) > > + - interrupt-parent: a phandle pointing to the interrupt controlle= r > > + serving the interrupt for this chip > > + - interrupts: interrupt specification for this chip >=20 > How many? What are they for? > I'll change it to:=20 | - interrupts: interrupt specification for the touchdetect | interrupt > > + - report_rate: allows setting the report rate in the range from 3= to > > + 14. >=20 > However, why can the kernel not decide the report rate? This doesn't > sound like something that needs to vary per-board. >=20 > Also, s/_/-/ in property names, please. >=20 OK, I'll drop the property, which also simplyfies the code a bit. > > +#define EDT_GET_PROP(name, reg) { \ > > + const u32 *prop =3D of_get_property(np, #name, NULL); \ > > + if (prop) \ > > + edt_ft5x06_register_write(tsdata, reg, be32_to_cpu(*prop)); \ > > +} >=20 > Use of_property_read_u32, it'll handle endianness conversion for you. >=20 > Use of of_get_property is almost always wrong. >=20 Sure. Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________