From: Mark Rutland <mark.rutland@arm.com>
To: "jon@ringle.org" <jon@ringle.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jslaby@suse.cz" <jslaby@suse.cz>,
"shc_work@mail.ru" <shc_work@mail.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Jon Ringle <jringle@gridpoint.com>
Subject: Re: [PATCH] tty: serial: sc16is7xx
Date: Thu, 20 Mar 2014 14:08:48 +0000 [thread overview]
Message-ID: <20140320140848.GB23372@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1395324177-15311-1-git-send-email-jon@ringle.org>
On Thu, Mar 20, 2014 at 02:02:57PM +0000, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
>
> The SC16IS7xx is a slave I2C-bus/SPI interface to a single-channel
> high performance UART. The SC16IS7xx’s internal register set is
> backward-compatible with the widely used and widely popular 16C450.
>
> The SC16IS7xx also provides additional advanced features such as
> auto hardware and software flow control, automatic RS-485 support, and
> software reset.
>
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
> drivers/tty/serial/Kconfig | 10 +
> drivers/tty/serial/Makefile | 1 +
> drivers/tty/serial/sc16is7xx.c | 1258 ++++++++++++++++++++++++++++++++++++++
> include/uapi/linux/serial_core.h | 3 +
> 4 files changed, 1272 insertions(+)
> create mode 100644 drivers/tty/serial/sc16is7xx.c
[...]
> +static const struct of_device_id __maybe_unused sc16is7xx_dt_ids[] = {
> + { .compatible = "nxp,sc16is740", .data = &sc16is74x_devtype, },
> + { .compatible = "nxp,sc16is741", .data = &sc16is74x_devtype, },
> + { .compatible = "nxp,sc16is750", .data = &sc16is750_devtype, },
> + { .compatible = "nxp,sc16is752", .data = &sc16is752_devtype, },
> + { .compatible = "nxp,sc16is760", .data = &sc16is760_devtype, },
> + { .compatible = "nxp,sc16is762", .data = &sc16is762_devtype, },
> + { }
> +};
Please document these strings (even if under a trivial binding
document).
Cheers,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-03-20 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 14:02 [PATCH] tty: serial: sc16is7xx jon
2014-03-20 14:08 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320140848.GB23372@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jon@ringle.org \
--cc=jringle@gridpoint.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).