[PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on

[PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on

[Lothar Waßmann]

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 arch/arm/boot/dts/imx53-tx53-x13x.dts |    2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
index 6480471..c8a3473 100644
--- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
@@ -72,7 +72,6 @@
 			regulator-max-microvolt = <3300000>;
 			gpio = <&gpio3 29 GPIO_ACTIVE_HIGH>;
 			enable-active-high;
-			regulator-boot-on;
 		};
 
 		reg_lcd_pwr1: regulator@6 {
@@ -83,7 +82,6 @@
 			regulator-max-microvolt = <3300000>;
 			gpio = <&gpio2 31 GPIO_ACTIVE_HIGH>;
 			enable-active-high;
-			regulator-boot-on;
 		};
 	};
 };
-- 
1.7.10.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/5] ARM: dts: tx53: sort the i2c subnodes by I2C address

[Lothar Waßmann]

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 arch/arm/boot/dts/imx53-tx53-x13x.dts |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
index c8a3473..cd3476b 100644
--- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
@@ -108,14 +108,6 @@
 	pinctrl-0 = <&pinctrl_i2c3>;
 	status = "okay";
 
-	sgtl5000: codec@0a {
-		compatible = "fsl,sgtl5000";
-		reg = <0x0a>;
-		VDDA-supply = <&reg_2v5>;
-		VDDIO-supply = <&reg_3v3>;
-		clocks = <&mclk>;
-	};
-
 	touchscreen1: eeti@04 {
 		compatible = "eeti,egalax_ts";
 		reg = <0x04>;
@@ -126,6 +118,14 @@
 		wakeup-gpios = <&gpio3 22 GPIO_ACTIVE_HIGH>;
 		linux,wakeup;
 	};
+
+	sgtl5000: codec@0a {
+		compatible = "fsl,sgtl5000";
+		reg = <0x0a>;
+		VDDA-supply = <&reg_2v5>;
+		VDDIO-supply = <&reg_3v3>;
+		clocks = <&mclk>;
+	};
 };
 
 &iomuxc {
-- 
1.7.10.4

[PATCH 4/5] ARM: dts: tx53: add simple-panel support

[Lothar Waßmann]

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 arch/arm/boot/dts/imx53-tx53-x13x.dts |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
index 26b918e..86a964d 100644
--- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
@@ -63,6 +63,18 @@
 		default-brightness-level = <50>;
 	};
 
+	panel0 {
+		compatible = "simple-panel";
+		power-supply = <&reg_lcd_pwr0>;
+		backlight = <&backlight0>;
+	};
+
+	panel1 {
+		compatible = "simple-panel";
+		power-supply = <&reg_lcd_pwr1>;
+		backlight = <&backlight1>;
+	};
+
 	regulators {
 		reg_lcd_pwr0: regulator@5 {
 			compatible = "regulator-fixed";
-- 
1.7.10.4

Re: [PATCH 4/5] ARM: dts: tx53: add simple-panel support

[Shawn Guo]

On Wed, Mar 19, 2014 at 02:28:40PM +0100, Lothar Waßmann wrote:
> 
> Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
> ---
>  arch/arm/boot/dts/imx53-tx53-x13x.dts |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> index 26b918e..86a964d 100644
> --- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
> +++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> @@ -63,6 +63,18 @@
>  		default-brightness-level = <50>;
>  	};
>  
> +	panel0 {
> +		compatible = "simple-panel";

From what I can see, "simple-panel" is not a documented compatible.

Shawn

> +		power-supply = <&reg_lcd_pwr0>;
> +		backlight = <&backlight0>;
> +	};
> +
> +	panel1 {
> +		compatible = "simple-panel";
> +		power-supply = <&reg_lcd_pwr1>;
> +		backlight = <&backlight1>;
> +	};
> +
>  	regulators {
>  		reg_lcd_pwr0: regulator@5 {
>  			compatible = "regulator-fixed";
> -- 
> 1.7.10.4
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/5] ARM: dts: tx53: add simple-panel support

[Lothar Waßmann]

Hi,

Shawn Guo wrote:
> On Wed, Mar 19, 2014 at 02:28:40PM +0100, Lothar Waßmann wrote:
> > 
> > Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/imx53-tx53-x13x.dts |   12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> > index 26b918e..86a964d 100644
> > --- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
> > +++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> > @@ -63,6 +63,18 @@
> >  		default-brightness-level = <50>;
> >  	};
> >  
> > +	panel0 {
> > +		compatible = "simple-panel";
> 
> From what I can see, "simple-panel" is not a documented compatible.
> 
There is Documentation/devicetree/bindings/panel/simple-panel.txt
which describes the bindings for drivers/gpu/drm/panel/panel-simple.c.
"simple-panel" is the common compatible for all panels that the driver
supports. If no compatible for a specific panel is given, the
driver supports a generic panel with an ENABLE GPIO, an attached
backlight and a regulator. This is what's being used here. 


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info-AvR2QvxeiV7DiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 5/5] ARM: dts: tx53: Add IPU DI ports and endpoints

[Lothar Waßmann]

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 arch/arm/boot/dts/imx53-tx53-x03x.dts |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts b/arch/arm/boot/dts/imx53-tx53-x03x.dts
index 0217dde3..43b4b7b 100644
--- a/arch/arm/boot/dts/imx53-tx53-x03x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts
@@ -25,12 +25,17 @@
 	soc {
 		display: display@di0 {
 			compatible = "fsl,imx-parallel-display";
-			crtcs = <&ipu 0>;
 			interface-pix-fmt = "rgb24";
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_rgb24_vga1>;
 			status = "okay";
 
+			port {
+				display0_in: endpoint {
+					remote-endpoint = <&ipu_di0_disp0>;
+				};
+			};
+
 			display-timings {
 				VGA {
 					clock-frequency = <25200000>;
-- 
1.7.10.4

Re: [PATCH 5/5] ARM: dts: tx53: Add IPU DI ports and endpoints

[Shawn Guo]

On Wed, Mar 19, 2014 at 02:28:41PM +0100, Lothar Waßmann wrote:
> 
> Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
> ---
>  arch/arm/boot/dts/imx53-tx53-x03x.dts |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> index 0217dde3..43b4b7b 100644
> --- a/arch/arm/boot/dts/imx53-tx53-x03x.dts
> +++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> @@ -25,12 +25,17 @@
>  	soc {
>  		display: display@di0 {
>  			compatible = "fsl,imx-parallel-display";
> -			crtcs = <&ipu 0>;
>  			interface-pix-fmt = "rgb24";
>  			pinctrl-names = "default";
>  			pinctrl-0 = <&pinctrl_rgb24_vga1>;
>  			status = "okay";
>  
> +			port {
> +				display0_in: endpoint {
> +					remote-endpoint = <&ipu_di0_disp0>;
> +				};
> +			};
> +

I shouldn't apply this until I rebase my branch on 3.15-rc1 where
Philipp's OF graph is to be seen, right?

Shawn

>  			display-timings {
>  				VGA {
>  					clock-frequency = <25200000>;
> -- 
> 1.7.10.4
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/5] ARM: dts: tx53: Add IPU DI ports and endpoints

[Lothar Waßmann]

Hi,

Shawn Guo wrote:
> On Wed, Mar 19, 2014 at 02:28:41PM +0100, Lothar Waßmann wrote:
> > 
> > Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/imx53-tx53-x03x.dts |    7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> > index 0217dde3..43b4b7b 100644
> > --- a/arch/arm/boot/dts/imx53-tx53-x03x.dts
> > +++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> > @@ -25,12 +25,17 @@
> >  	soc {
> >  		display: display@di0 {
> >  			compatible = "fsl,imx-parallel-display";
> > -			crtcs = <&ipu 0>;
> >  			interface-pix-fmt = "rgb24";
> >  			pinctrl-names = "default";
> >  			pinctrl-0 = <&pinctrl_rgb24_vga1>;
> >  			status = "okay";
> >  
> > +			port {
> > +				display0_in: endpoint {
> > +					remote-endpoint = <&ipu_di0_disp0>;
> > +				};
> > +			};
> > +
> 
> I shouldn't apply this until I rebase my branch on 3.15-rc1 where
> Philipp's OF graph is to be seen, right?
> 
That's ok with me.


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info-AvR2QvxeiV7DiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/5] ARM: dts: tx53: fix LVDS display mappings

[Lothar Waßmann]

The data-mapping and data-width settings were opposite of what the
display requires. Interestingly, these settings nevertheless produced
correct results.

Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
---
 arch/arm/boot/dts/imx53-tx53-x13x.dts |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
index cd3476b..26b918e 100644
--- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
@@ -181,8 +181,8 @@
 	status = "okay";
 
 	lvds0: lvds-channel@0 {
-		fsl,data-mapping = "jeida";
-		fsl,data-width = <24>;
+		fsl,data-mapping = "spwg";
+		fsl,data-width = <18>;
 		status = "okay";
 
 		display-timings {
@@ -206,8 +206,8 @@
 	};
 
 	lvds1: lvds-channel@1 {
-		fsl,data-mapping = "jeida";
-		fsl,data-width = <24>;
+		fsl,data-mapping = "spwg";
+		fsl,data-width = <18>;
 		status = "okay";
 
 		display-timings {
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on

[Shawn Guo]

On Wed, Mar 19, 2014 at 02:28:37PM +0100, Lothar Waßmann wrote:
> 
> Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>

Please add something in the commit log, e.g. why regulator-boot-on is
redundant in this case.

Shawn

> ---
>  arch/arm/boot/dts/imx53-tx53-x13x.dts |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> index 6480471..c8a3473 100644
> --- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
> +++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> @@ -72,7 +72,6 @@
>  			regulator-max-microvolt = <3300000>;
>  			gpio = <&gpio3 29 GPIO_ACTIVE_HIGH>;
>  			enable-active-high;
> -			regulator-boot-on;
>  		};
>  
>  		reg_lcd_pwr1: regulator@6 {
> @@ -83,7 +82,6 @@
>  			regulator-max-microvolt = <3300000>;
>  			gpio = <&gpio2 31 GPIO_ACTIVE_HIGH>;
>  			enable-active-high;
> -			regulator-boot-on;
>  		};
>  	};
>  };
> -- 
> 1.7.10.4
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on

[Lothar Waßmann]

Hi,

Shawn Guo wrote:
> On Wed, Mar 19, 2014 at 02:28:37PM +0100, Lothar Waßmann wrote:
> > 
> > Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
> 
> Please add something in the commit log, e.g. why regulator-boot-on is
> redundant in this case.
> 
OK.


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info-AvR2QvxeiV7DiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html