From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node. Date: Mon, 24 Mar 2014 10:45:14 +0800 Message-ID: <20140324023900.GA4002@dragon> References: <1395292325-8497-2-git-send-email-Li.Xiubo@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1395292325-8497-2-git-send-email-Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Xiubo Li Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Mar 20, 2014 at 01:12:03PM +0800, Xiubo Li wrote: > This adds devicetree node for VF610, and there are 8 channels > supported. > > Signed-off-by: Xiubo Li > Reviewed-by: Sascha Hauer > Reviewed-by: Yuan Yao Please copy list linux-arm-kernel instead of linux-kernel on arch/arm/ changes, and also be noted that my email and git addresses just got updated [1]. > --- > arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi > index acf544e..ccc6d35 100644 > --- a/arch/arm/boot/dts/vf610.dtsi > +++ b/arch/arm/boot/dts/vf610.dtsi > @@ -192,6 +192,19 @@ > status = "disabled"; > }; > > + pwm0: pwm@40038000 { The node should be sorted in unit-address. So shouldn't it be put right after pit node? Shawn [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f1c12837220c54c8d7138a4ee4a08c1ec67b68a2 > + compatible = "fsl,vf610-ftm-pwm"; > + #pwm-cells = <3>; > + reg = <0x40038000 0x1000>; > + clock-names = "ftm_sys", "ftm_ext", > + "ftm_fix", "ftm_cnt_clk_en"; > + clocks = <&clks VF610_CLK_FTM0>, > + <&clks VF610_CLK_FTM0_EXT_SEL>, > + <&clks VF610_CLK_FTM0_FIX_SEL>, > + <&clks VF610_CLK_FTM0_EXT_FIX_EN>; > + status = "disabled"; > + }; > + > wdog@4003e000 { > compatible = "fsl,vf610-wdt", "fsl,imx21-wdt"; > reg = <0x4003e000 0x1000>; > -- > 1.8.4 > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html