From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH v3] i2c: new bus driver for efm32 Date: Tue, 25 Mar 2014 13:00:59 +0100 Message-ID: <20140325120059.GA2863@katana> References: <1395414236-22647-1-git-send-email-u.kleine-koenig@pengutronix.de> <20140324170131.GB7524@katana> <20140325090700.GL23076@pengutronix.de> <20140325091148.GA2570@katana> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zYM0uCDKw75PZbzx" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Whitcroft Cc: Joe Perches , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Uwe =?iso-8859-15?Q?Kleine-K=F6nig?= , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org List-Id: devicetree@vger.kernel.org --zYM0uCDKw75PZbzx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 25, 2014 at 11:17:49AM +0000, Andy Whitcroft wrote: > I would call it a false positive and ignore it.=A0 You need to justify any > reports from checkpatch that remain "this is more readable" seems a valid > justification. I agree in general. In this case, I think both options have their pros and cons in terms of readability, so I let the author decide. --zYM0uCDKw75PZbzx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBAgAGBQJTMW/7AAoJEBQN5MwUoCm21ZEP/21C+IpKpWV/tUtCUt0rh5Dy EgRPl9BWzarYsOmlGUQcULPRFlamauAmPA2t8mXWOG1TMKvnbtAgaSg9YpBmLmf4 4BWN6/12wQRQ00P9lvUoWq76i7YWfbbCFCrgneJJGi8KB6A3oY+rCqKRuWdYbOs1 7t/64H7Emm4GWGS/yH6wN0q/LJTeIS2YVkc+s694QQQblCfmKlIFFccFxM24+NNd V6NLgVD6+2/WPRzFGxaaCQsnksEsiRgwpZi5zqYBQ1kuK9JDqaNmjn2AJy001KTE vIcTqTBJfxuNVQah7/k2PRkGKGpJBzYcTCwsaGWN2l3+fp0te9m0LQTpW9AEzDG3 HpSwfY+ZVaWITyua9bFY/LMe/2k1McqgxLcrmDcMrPFZUn3g7ywCnwFdxg2X2zRA FOkFgH1R3hxPg3p5mp7oR2/oKbP7CpnQgI4l10mn7l4nv29xBcibV54Xs5Mjahjt w6Bu8Phh/DNIa21BNInOqAdKVriEPARcpMyVmgIgSIoqYrGBgfqRvD8eoZRMNGu1 HzQcWChF8LZnbn+UhFGGbdJbtGMDO/h76orq458v5JhK7W74FirabRBU/vDzF3FL x/Xt6mMZvzUgKIykg8+CjZSvJUoSdKHCOjh6nWZU3W+EwrR9nJeSJoaC//irHdB0 X0cAjtXA03z7MODSUVtZ =LhVR -----END PGP SIGNATURE----- --zYM0uCDKw75PZbzx--