From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Huang Shijie <b32955@freescale.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <fabio.estevam@freescale.com>,
Mark Rutland <mark.rutland@arm.com>,
Brian Norris <computersforpeace@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>, Arnd Bergmann <arnd@arndb.de>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org,
Shawn Guo <shawn.guo@freescale.com>,
Rob Landley <rob@landley.net>, Kumar Gala <galak@codeaurora.org>,
Shawn Guo <shawn.guo@linaro.org>,
David Woodhouse <dwmw2@infradead.org>,
Sascha Hauer <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional
Date: Fri, 28 Mar 2014 11:18:05 +0100 [thread overview]
Message-ID: <20140328111805.76b6513d@ipc1.ka-ro> (raw)
In-Reply-To: <53354A46.9040807@freescale.com>
Hi,
Huang Shijie wrote:
> 于 2014年03月28日 17:31, Lothar Waßmann 写道:
> > Hi,
> >
> > Huang Shijie wrote:
> >> 于 2014年03月28日 17:00, Sascha Hauer 写道:
> >>> - disables swapping of BB marks in the FCB the ROM won't swap bytes.
> >> We can not disable the swapping in the FCB in the imx28.
> >> The DISBBM bit in the FCB does _NOT_ exit in the imx28's FCB.
> >>
> > The Linux kernel does not have any business with the FCB, so it is
> > completely irrelevant for Linux whether byte swapping can be disabled
> > in the FCB or not.
> >
> But the gpmi is relevant to the ROM.
> the gpmi driver should keep consistency with the ROM.
>
> I do not object you add the swapping optional the gpmi driver(since it's
> ok for imx50/imx6q/imx6sx),
> i just object that you enable this feature for imx28.
>
We are talking about a Linux Kernel Driver here, not about a flashtool
for i.MX28.
It is a valid usecase for Linux not being able to write the bootloader,
so there is no reason to disallow this feature in the driver code.
Since it is a DT option it can be trivially switched on and off without
having to change anything in the kernel.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________
next prev parent reply other threads:[~2014-03-28 10:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1395235406-13449-1-git-send-email-y>
2014-03-20 8:33 ` [PATCH] mtd: gpmi: make blockmark swapping optional Juergen Beisert
2014-03-20 9:20 ` Lothar Waßmann
2014-03-20 9:15 ` Huang Shijie
2014-03-20 9:21 ` Lothar Waßmann
2014-03-20 9:47 ` Huang Shijie
2014-03-20 10:09 ` Lothar Waßmann
2014-03-20 10:56 ` Huang Shijie
2014-03-21 5:36 ` Huang Shijie
[not found] ` <532BCFCC.4080205-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-03-21 10:50 ` [PATCHv2 1/1] " Lothar Waßmann
2014-03-24 9:59 ` Huang Shijie
2014-03-26 8:51 ` Lothar Waßmann
2014-03-26 10:41 ` Huang Shijie
2014-03-26 11:55 ` Lothar Waßmann
2014-03-27 9:59 ` Huang Shijie
2014-03-27 12:21 ` Lothar Waßmann
2014-03-28 2:09 ` Huang Shijie
2014-03-28 8:16 ` Lothar Waßmann
2014-03-28 8:39 ` Huang Shijie
2014-03-28 9:00 ` Sascha Hauer
2014-03-28 9:26 ` Huang Shijie
2014-03-28 9:31 ` Lothar Waßmann
2014-03-28 10:09 ` Huang Shijie
2014-03-28 10:18 ` Lothar Waßmann [this message]
2014-03-28 9:01 ` Lothar Waßmann
2014-03-28 9:33 ` Huang Shijie
2014-03-28 9:38 ` Huang Shijie
2014-03-28 10:13 ` Lothar Waßmann
2014-03-28 10:35 ` [PATCHv3 0/2] " Lothar Waßmann
2014-03-28 10:35 ` [PATCHv3 1/2] " Lothar Waßmann
2014-03-31 2:06 ` Huang Shijie
2014-03-28 10:35 ` [PATCHv3 2/2] of/mtd/nand: add generic binding and helper for NAND_BBT_NO_OOB_BBM Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328111805.76b6513d@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=arnd@arndb.de \
--cc=artem.bityutskiy@linux.intel.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@freescale.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@freescale.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).