From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH/RFC v2 4/8] leds: Add support for max77693 mfd flash cell Date: Mon, 31 Mar 2014 08:48:08 +0100 Message-ID: <20140331074808.GM17779@lee--X1> References: <1396020545-15727-1-git-send-email-j.anaszewski@samsung.com> <1396020545-15727-5-git-send-email-j.anaszewski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1396020545-15727-5-git-send-email-j.anaszewski@samsung.com> Sender: linux-media-owner@vger.kernel.org To: Jacek Anaszewski Cc: linux-media@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, s.nawrocki@samsung.com, a.hajda@samsung.com, kyungmin.park@samsung.com, Bryan Wu , Richard Purdie , SangYoung Son , Samuel Ortiz List-Id: devicetree@vger.kernel.org On Fri, 28 Mar 2014, Jacek Anaszewski wrote: > This patch adds led-flash support to Maxim max77693 chipset. > Device can be exposed to user space through LED subsystem > sysfs interface or through V4L2 subdevice when the support > for Multimedia Framework is enabled. Device supports up to > two leds which can work in flash and torch mode. Leds can > be triggered externally or by software. >=20 > Signed-off-by: Andrzej Hajda > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > Cc: SangYoung Son > Cc: Samuel Ortiz > Cc: Lee Jones > --- > drivers/leds/Kconfig | 10 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-max77693.c | 864 ++++++++++++++++++++++++++++++++= ++++++++++ > drivers/mfd/max77693.c | 3 +- > include/linux/mfd/max77693.h | 32 ++ > 5 files changed, 909 insertions(+), 1 deletion(-) > create mode 100644 drivers/leds/leds-max77693.c [...] > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > index c5535f0..d53c497 100644 > --- a/drivers/mfd/max77693.c > +++ b/drivers/mfd/max77693.c > @@ -44,7 +44,8 @@ > static const struct mfd_cell max77693_devs[] =3D { > { .name =3D "max77693-pmic", }, > { .name =3D "max77693-charger", }, > - { .name =3D "max77693-flash", }, > + { .name =3D "max77693-flash", > + .of_compatible =3D "maxim,max77693-flash", }, On one line please. > { .name =3D "max77693-muic", }, > { .name =3D "max77693-haptic", }, > }; > diff --git a/include/linux/mfd/max77693.h b/include/linux/mfd/max7769= 3.h > index 3f3dc45..5859698 100644 > --- a/include/linux/mfd/max77693.h > +++ b/include/linux/mfd/max77693.h > @@ -63,6 +63,37 @@ struct max77693_muic_platform_data { > int path_uart; > }; > =20 > +/* MAX77693 led flash */ > + > +/* triggers */ > +#define MAX77693_LED_TRIG_OFF 0 > +#define MAX77693_LED_TRIG_FLASH 1 > +#define MAX77693_LED_TRIG_TORCH 2 > +#define MAX77693_LED_TRIG_EXT (MAX77693_LED_TRIG_FLASH |\ > + MAX77693_LED_TRIG_TORCH) > +#define MAX77693_LED_TRIG_SOFT 4 > + > +/* trigger types */ > +#define MAX77693_LED_TRIG_TYPE_EDGE 0 > +#define MAX77693_LED_TRIG_TYPE_LEVEL 1 > + > +/* boost modes */ > +#define MAX77693_LED_BOOST_NONE 0 > +#define MAX77693_LED_BOOST_ADAPTIVE 1 > +#define MAX77693_LED_BOOST_FIXED 2 I think it would be better to enum all of the above. > +struct max77693_led_platform_data { > + u32 iout[4]; > + u32 trigger[4]; > + u32 trigger_type[2]; > + u32 timeout[2]; > + u32 boost_mode[2]; > + u32 boost_vout; > + u32 low_vsys; > +}; I'll leave this LED stuff to the expert(s). [...] --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog