From: Mike Turquette <mturquette@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Ben Dooks <ben-linux@fluff.org>, Tomasz Figa <t.figa@samsung.com>,
Vyacheslav Tyrtov <v.tyrtov@samsung.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Heiko Stuebner <heiko@sntech.de>,
Romain Naour <romain.naour@openwide.fr>,
Chander Kashyap <chander.kashyap@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Tarek Dakhran <t.dakhran@gmail.com>,
Tarek Dakhran <t.dakhran@samsung.com>
Subject: Re: [PATCH v7 2/3] clk: exynos5410: register clocks using common clock framework
Date: Wed, 02 Apr 2014 21:21:39 -0700 [thread overview]
Message-ID: <20140403042139.5762.23354@quantum> (raw)
In-Reply-To: <1393213435-20863-3-git-send-email-t.dakhran@samsung.com>
Quoting Tarek Dakhran (2014-02-23 19:43:54)
> +External clock:
> +
> +There is clock that is generated outside the SoC. It is expected
> +that it is defined using standard clock bindings with following
> +clock-output-name:
> + - "fin_pll" - PLL input clock - required.
<snip>
> +Example 2: Required external clock.
> +
> + fin_pll: clock-fin-pll {
> + compatible = "fixed-clock";
> + reg = <0>;
> + #clock-cells = <0>;
> + clock-frequency = <24000000>;
> + clock-output-names = "fin_pll";
> + };
I guess this part is a little strange for a binding definition.
Basically this is DTS data specific to 5410; not sure why it belongs in
the DT binding definition.
Rest of the clock driver appears OK to me.
Regards,
Mike
next prev parent reply other threads:[~2014-04-03 4:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 3:43 [PATCH v7 0/3] Exynos 5410 support Tarek Dakhran
2014-02-24 3:43 ` [PATCH v7 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC Tarek Dakhran
2014-02-24 3:43 ` [PATCH v7 2/3] clk: exynos5410: register clocks using common clock framework Tarek Dakhran
2014-04-03 4:21 ` Mike Turquette [this message]
2014-02-24 3:43 ` [PATCH v7 3/3] ARM: dts: Add initial device tree support for EXYNOS5410 Tarek Dakhran
2014-04-02 23:05 ` [PATCH v7 0/3] Exynos 5410 support Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403042139.5762.23354@quantum \
--to=mturquette@linaro.org \
--cc=ben-linux@fluff.org \
--cc=chander.kashyap@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=romain.naour@openwide.fr \
--cc=t.dakhran@gmail.com \
--cc=t.dakhran@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
--cc=v.tyrtov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).