From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Porter Subject: Re: [PATCH v3 1/3] pinctrl: Rename Broadcom Capri pinctrl driver Date: Thu, 10 Apr 2014 13:57:10 -0400 Message-ID: <20140410175710.GD23695@beef> References: <1390509887-19278-1-git-send-email-syin@broadcom.com> <1396478439-16586-1-git-send-email-syin@broadcom.com> <1396478439-16586-2-git-send-email-syin@broadcom.com> <20140410165626.GB23695@beef> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Sherman Yin , Mark Brown , Heiko =?iso-8859-1?Q?St=FCbner?= , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Christian Daudt , Russell King , Grant Likely , Olof Johansson , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , bcm-kernel-feedback-list , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Thu, Apr 10, 2014 at 07:41:20PM +0200, Linus Walleij wrote: > On Thu, Apr 10, 2014 at 6:56 PM, Matt Porter wrote: > > On Thu, Apr 10, 2014 at 06:51:12PM +0200, Linus Walleij wrote: > >> On Thu, Apr 10, 2014 at 6:49 PM, Linus Walleij wrote: > >> > On Thu, Apr 3, 2014 at 12:40 AM, Sherman Yin wrote: > >> > > >> >> To be consistent with other Broadcom drivers, the Broadcom Capri pinctrl > >> >> driver and its related CONFIG option are renamed to bcm281xx. > >> >> > >> >> Devicetree compatible string and binding documentation use > >> >> "brcm,bcm11351-pinctrl" to match the machine binding here: > >> >> Documentation/devicetree/bindings/arm/bcm/bcm11351.txt > >> >> > >> >> This driver supports pinctrl on BCM11130, BCM11140, BCM11351, BCM28145 > >> >> and BCM28155 SoCs. > >> >> > >> >> Signed-off-by: Sherman Yin > >> >> Reviewed-by: Matt Porter > >> >> Acked-by: Linus Walleij > >> >> --- > >> >> drivers/pinctrl/Kconfig | 8 +- > >> >> drivers/pinctrl/Makefile | 2 +- > >> >> .../{pinctrl-capri.c => pinctrl-bcm281xx.c} | 1519 ++++++++++---------- > >> > > >> > This last version from apr 7 does not change > >> > arch/arm/configs/bcm_defconfig:CONFIG_PINCTRL_CAPRI=y > >> > > >> > Doesn't this mean that you render this platform without a pin > >> > control driver and thus broken? > >> > >> Bah I see that it's a separate patch now, sorry... > >> > >> Looking closer. > > > > I can take that one through mach-bcm for 3.16 to keep these changes > > in one place. > > Nah I might as well take all of it through the pin control tree. > Can I have your ACK on the defconfig change? Sounds fine to me, done. -Matt