From: Lee Jones <lee.jones@linaro.org>
To: Huang Shijie <shijie8@gmail.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
Huang Shijie <b32955@freescale.com>,
angus.clark@st.com, Russel King <linux@arm.linux.org.uk>,
broonie@linaro.org, dwmw2@infradead.org,
linux-doc@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
pekon@ti.com, sourav.poddar@ti.com, shawn.guo@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 5/8 fix] mtd: m25p80: use the SPI nor framework
Date: Fri, 11 Apr 2014 08:04:14 +0100 [thread overview]
Message-ID: <20140411070414.GA9801@lee--X1> (raw)
In-Reply-To: <20140411003203.GC3837@localhost.localdomain>
On Fri, 11 Apr 2014, Huang Shijie wrote:
> On Thu, Apr 10, 2014 at 12:29:02PM -0700, Brian Norris wrote:
> > > IMHO, we should create a patch or several patches to add the MTD_SPI_NOR
> > > to the defconfigs.
> >
> > Yeah, I think that's best.
> I will create a patch when i back to office.
> Or you can create it yourself.
>
> >
> > > > Also, I think m25p80.c is no longer a "self-contained MTD device driver"
> > > > and should be moved under drivers/mtd/spi-nor/.
> > > If we move the m25p80.c to the drivers/mtd/spi-nor/, we also need to move
> > > other drivers too.
> >
> > Which ones? I think it only makes sense to move those that depend on the
> > same core code (i.e., spi-nor.c), or have a close relation to it (so
> > Lee's st_spi_fsm.c is a candidate).
>
> yes, i mean the st_spi_fsm.c and other drivers which will use the
> spi-nor core code in the future.
+1 - happy with this.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-04-11 7:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 10:37 [PATCH v5 0/8] mtd: spi-nor: add a new framework for SPI NOR Huang Shijie
2014-02-24 10:37 ` [PATCH v5 1/8] mtd: spi-nor: copy the SPI NOR commands to a new header file Huang Shijie
[not found] ` <1393238262-8622-2-git-send-email-b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-03-04 22:13 ` Marek Vasut
2014-03-05 2:59 ` Huang Shijie
[not found] ` <5316932C.5040405-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-03-05 3:43 ` Marek Vasut
2014-03-05 5:45 ` Huang Shijie
2014-03-05 7:24 ` Gupta, Pekon
2014-03-05 13:36 ` Marek Vasut
2014-04-09 17:40 ` Brian Norris
2014-02-24 10:37 ` [PATCH v5 4/8] Documentation: add the document for the SPI NOR framework Huang Shijie
2014-02-24 15:17 ` Konstantin Tokarev
[not found] ` <203101393255036-NPKjhoV82L1xpj1cXAZ9Bg@public.gmane.org>
2014-02-25 2:23 ` Huang Shijie
2014-02-28 7:58 ` [PATCH v5 4/8 fix] " Huang Shijie
[not found] ` <1393238262-8622-1-git-send-email-b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-02-24 10:37 ` [PATCH v5 2/8] mtd: spi-nor: add the basic data structures Huang Shijie
2014-02-24 10:37 ` [PATCH v5 3/8] mtd: spi-nor: add the framework for SPI NOR Huang Shijie
2014-04-09 17:48 ` Brian Norris
2014-04-10 7:27 ` Huang Shijie
2014-02-24 10:37 ` [PATCH v5 5/8] mtd: m25p80: use the SPI nor framework Huang Shijie
2014-02-28 7:55 ` [PATCH v5 5/8 fix] " Huang Shijie
2014-04-09 21:37 ` Brian Norris
2014-04-10 7:25 ` Huang Shijie
2014-04-10 19:29 ` Brian Norris
2014-04-11 0:32 ` Huang Shijie
2014-04-11 7:04 ` Lee Jones [this message]
2014-02-24 10:37 ` [PATCH v5 6/8] mtd: spi-nor: add a helper to find the spi_device_id Huang Shijie
2014-02-24 10:37 ` [PATCH v5 7/8] Documentation: add the binding file for Freescale QuadSPI driver Huang Shijie
2014-03-12 8:13 ` [PATCH v5 0/8] mtd: spi-nor: add a new framework for SPI NOR Huang Shijie
[not found] ` <20140312081350.GC30808-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2014-03-13 6:39 ` Brian Norris
2014-04-09 3:36 ` Brian Norris
2014-04-09 4:29 ` Huang Shijie
2014-04-09 17:47 ` Marek Vasut
2014-04-10 7:42 ` Lee Jones
2014-04-10 19:31 ` Brian Norris
2014-02-24 10:37 ` [PATCH v5 8/8] mtd: spi-nor: Add Freescale QuadSPI driver Huang Shijie
2014-03-04 22:17 ` [PATCH v5 0/8] mtd: spi-nor: add a new framework for SPI NOR Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411070414.GA9801@lee--X1 \
--to=lee.jones@linaro.org \
--cc=angus.clark@st.com \
--cc=b32955@freescale.com \
--cc=broonie@linaro.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pekon@ti.com \
--cc=shawn.guo@linaro.org \
--cc=shijie8@gmail.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).