From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: "sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"alexandre.belloni@free-electrons.com"
<alexandre.belloni@free-electrons.com>,
Jimmy Xu <zmxu@marvell.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND 4/5] Documentation: add the Marvell Berlin pinctrl documentation
Date: Fri, 11 Apr 2014 10:12:59 +0200 [thread overview]
Message-ID: <20140411081259.GA20147@kwain> (raw)
In-Reply-To: <20140411143318.67e55a17@xhacker>
Hi Jisheng,
On Fri, Apr 11, 2014 at 02:33:18PM +0800, Jisheng Zhang wrote:
> On Thu, 10 Apr 2014 06:07:53 -0700
> Antoine Ténart <antoine.tenart@free-electrons.com> wrote:
> > +Required subnode-properties:
> > +- berlin,group: a string describing the group's name.
> > +- berlin,function: the function used to mux the group.
>
> Would it be better to s/function/mode? Because in mrvl internal technology
> discussion and docs, we usually say "set pinmux Gy as mode z".
The pinctrl framework uses 'function', so I guess it's better not to introduce
an other keyword that may confuse people. But I agree this is not what's used in
the Marvell's docs. What do you think about we mention it in this documentation ?
Thanks for the feedback !
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-11 8:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 13:07 [PATCH RESEND 0/5] ARM: berlin: add pinctrl support Antoine Ténart
2014-04-10 13:07 ` [PATCH RESEND 1/5] pinctrl: allows not to define the get_group_pins operation Antoine Ténart
2014-04-11 9:21 ` Sebastian Hesselbarth
[not found] ` <1397135274-10764-2-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-04-22 12:48 ` Linus Walleij
[not found] ` <CACRpkdZrLZZwpVCzo_Ms2=7SqUoryt-6OtF7ePhGp4kwJgDgXQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-22 15:58 ` Antoine Ténart
2014-04-10 13:07 ` [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs Antoine Ténart
2014-04-11 6:44 ` Jisheng Zhang
2014-04-11 8:18 ` Antoine Ténart
2014-04-11 8:27 ` Jisheng Zhang
2014-04-11 9:21 ` Antoine Ténart
[not found] ` <1397135274-10764-3-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-04-11 9:03 ` Sebastian Hesselbarth
2014-04-11 12:37 ` Antoine Ténart
2014-04-11 13:35 ` Sebastian Hesselbarth
2014-04-22 12:52 ` Linus Walleij
[not found] ` <CACRpkdb1eijF-4e=KyhS=9S868NALdyJJaNnzjUubXnapWEeMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-22 15:56 ` Antoine Ténart
2014-04-23 14:05 ` Linus Walleij
2014-04-10 13:07 ` [PATCH RESEND 3/5] ARM: berlin: add the pinctrl dependency for the " Antoine Ténart
[not found] ` <1397135274-10764-4-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-04-11 9:05 ` Sebastian Hesselbarth
[not found] ` <5347B065.8060001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-17 13:13 ` Antoine Ténart
2014-04-17 13:24 ` Sebastian Hesselbarth
2014-04-10 13:07 ` [PATCH RESEND 4/5] Documentation: add the Marvell Berlin pinctrl documentation Antoine Ténart
2014-04-11 6:33 ` Jisheng Zhang
2014-04-11 8:12 ` Antoine Ténart [this message]
2014-04-11 8:18 ` Jisheng Zhang
2014-04-11 8:22 ` Andrew Lunn
2014-04-11 9:13 ` Sebastian Hesselbarth
[not found] ` <1397135274-10764-1-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-04-10 13:07 ` [PATCH RESEND 5/5] ARM: dts: berlin: add the pinctrl node and muxing setup for uarts Antoine Ténart
2014-04-11 8:18 ` Andrew Lunn
[not found] ` <20140411081859.GL10240-g2DYL2Zd6BY@public.gmane.org>
2014-04-11 9:09 ` Antoine Ténart
2014-04-11 9:19 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411081259.GA20147@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@marvell.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).