From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine =?iso-8859-1?Q?T=E9nart?= Subject: Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs Date: Fri, 11 Apr 2014 10:18:39 +0200 Message-ID: <20140411081839.GB20147@kwain> References: <1397135274-10764-1-git-send-email-antoine.tenart@free-electrons.com> <1397135274-10764-3-git-send-email-antoine.tenart@free-electrons.com> <20140411144431.04fb148d@xhacker> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20140411144431.04fb148d@xhacker> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jisheng Zhang Cc: "sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org" , Jimmy Xu , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi Jisheng, On Fri, Apr 11, 2014 at 02:44:31PM +0800, Jisheng Zhang wrote: > On Thu, 10 Apr 2014 06:07:51 -0700 > Antoine T=E9nart wrote: >=20 > ... > > +static int berlin_pinmux_enable(struct pinctrl_dev *pctrl_dev, > > + unsigned function, > > + unsigned group) > > +{ > > + struct berlin_pinctrl *pctrl =3D pinctrl_dev_get_drvdata(pc= trl_dev); > > + struct berlin_pinctrl_group *group_desc =3D pctrl->groups += group; > > + struct berlin_pinctrl_function *function_desc =3D > > + pctrl->functions + function; > > + unsigned long flags; > > + u32 regval; > > + > > + spin_lock_irqsave(&pctrl->lock, flags); > > + > > + regval =3D readl(group_desc->reg); > > + regval &=3D group_desc->mask; > > + regval |=3D function_desc->muxval << group_desc->lsb; > > + writel(regval, group_desc->reg); >=20 > Could we use relaxed version instead? We could, but this is not a performance issue here at all, so I guess w= e can keep writel(). Thanks for the feedback ! Antoine --=20 Antoine T=E9nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html