devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Loc Ho <lho-qTEPVZfXA3Y@public.gmane.org>
Cc: Alessandro Zummo
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Jon Masters <jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Rameshwar Prasad Sahu <rsahu-qTEPVZfXA3Y@public.gmane.org>,
	"patches-qTEPVZfXA3Y@public.gmane.org"
	<patches-qTEPVZfXA3Y@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v4 2/3] rtc: Add APM X-Gene SoC RTC driver
Date: Fri, 11 Apr 2014 10:28:56 +0100	[thread overview]
Message-ID: <20140411092856.GL6518@sirena.org.uk> (raw)
In-Reply-To: <CAPw-ZTns1EOT0inn0hq0Xh+CdjMkxhOkvL+_BnRThnm7HQC=BQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

On Thu, Apr 10, 2014 at 09:22:43PM -0700, Loc Ho wrote:

> I was modeled after driver rtc-coh901331.c. It seems like all I need
> here is to call clk_disable_unprepare() instead clk_disable for
> suspend. For resume, call clk_prepare_disable() instead clk_enable().
> No need to split them up. Am I correct?

Yes, the only reason the two operations are split is to support enabling
and disabling in interrupt context but you're not doing that.

> Given that Andrew Morton applied v2, should I post an patch against v2
> going forward?

Yes, once something has been applied you should only be sending
incremental patches.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      parent reply	other threads:[~2014-04-11  9:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 18:47 [PATCH v4 0/3] rtc: Add APM X-Gene SoC RTC driver Loc Ho
     [not found] ` <1397155678-26607-1-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2014-04-10 18:47   ` [PATCH v4 1/3] Documentation: Add documentation for the APM X-Gene SoC RTC DTS binding Loc Ho
     [not found]     ` <1397155678-26607-2-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2014-04-10 18:47       ` [PATCH v4 2/3] rtc: Add APM X-Gene SoC RTC driver Loc Ho
     [not found]         ` <1397155678-26607-3-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2014-04-10 18:47           ` [PATCH v4 3/3] arm64: Add APM X-Gene SoC RTC DTS entry Loc Ho
2014-04-10 22:42           ` [PATCH v4 2/3] rtc: Add APM X-Gene SoC RTC driver Mark Brown
     [not found]             ` <20140410224244.GH6518-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-04-11  4:22               ` Loc Ho
     [not found]                 ` <CAPw-ZTns1EOT0inn0hq0Xh+CdjMkxhOkvL+_BnRThnm7HQC=BQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-11  9:28                   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140411092856.GL6518@sirena.org.uk \
    --to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=lho-qTEPVZfXA3Y@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=patches-qTEPVZfXA3Y@public.gmane.org \
    --cc=rsahu-qTEPVZfXA3Y@public.gmane.org \
    --cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).