Re: [PATCH 1/4] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver

From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Alexander Stein <alexanders83@web.de>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Andrew Victor <linux@maxim.org.za>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	Grant Likely <grant.likely@linaro.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/4] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver
Date: Tue, 15 Apr 2014 00:48:39 +0200	[thread overview]
Message-ID: <20140414224838.GY2967@piout.net> (raw)
In-Reply-To: <1397293707-26890-2-git-send-email-alexanders83@web.de>

On 12/04/2014 at 11:08:24 +0200, Alexander Stein wrote :
> THis reduces some boilerplate code.
   ^
   small typo
> 
> Signed-off-by: Alexander Stein <alexanders83@web.de>
else
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  sound/atmel/ac97c.c | 15 ++-------------
>  1 file changed, 2 insertions(+), 13 deletions(-)
> 
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index c5f0ddd..9a13875 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -1202,6 +1202,7 @@ static int atmel_ac97c_remove(struct platform_device *pdev)
>  }
>  
>  static struct platform_driver atmel_ac97c_driver = {
> +	.probe		= atmel_ac97c_probe,
>  	.remove		= atmel_ac97c_remove,
>  	.driver		= {
>  		.name	= "atmel_ac97c",
> @@ -1209,19 +1210,7 @@ static struct platform_driver atmel_ac97c_driver = {
>  		.pm	= ATMEL_AC97C_PM_OPS,
>  	},
>  };
> -
> -static int __init atmel_ac97c_init(void)
> -{
> -	return platform_driver_probe(&atmel_ac97c_driver,
> -			atmel_ac97c_probe);
> -}
> -module_init(atmel_ac97c_init);
> -
> -static void __exit atmel_ac97c_exit(void)
> -{
> -	platform_driver_unregister(&atmel_ac97c_driver);
> -}
> -module_exit(atmel_ac97c_exit);
> +module_platform_driver(atmel_ac97c_driver);
>  
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("Driver for Atmel AC97 controller");
> -- 
> 1.9.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com