From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Rob Herring <robherring2@gmail.com>,
Tanmay Inamdar <tinamdar@apm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Arnd Bergmann <arnd@arndb.de>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Rob Landley <rob@landley.net>, Liviu Dudau <liviu.dudau@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"patches@apm.com" <patches@apm.com>,
"jcm@redhat.com" <jcm@redhat.com>
Subject: Re: [PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes
Date: Wed, 16 Apr 2014 15:21:04 -0600 [thread overview]
Message-ID: <20140416212104.GA3469@obsidianresearch.com> (raw)
In-Reply-To: <20140416170545.GD4858@bart>
On Wed, Apr 16, 2014 at 06:05:45PM +0100, Liviu Dudau wrote:
> I have found out that we cannot pasd the config ranges from the DT into the
> pci_host_bridge structure as the PCI framework doesn't have a resource type
> for config resources. Leaving the translation between range flags and
> resource type as is (filtered through the IORESOURCE_TYPE_BITS) will lead
> to a resource type of value zero, which is not recognised by any resource
> handling API so bridge configuration and bus scanning will barf.
>
> I'm looking for suggestions here, as Jason Gunthorpe suggested that we
> should be able to parse config ranges if they conform to the ECAM part
> of the PCI standard.
The thinking here is the ranges should be well defined and general, it
isn't a dumping ground for driver specific stuff.
No spec says you can put config space into the ranges at all, nobody
should be doing that today, obviously some cases were missed during
review..
The comment about ECAM was intended as a general guidance on what
config space in ranges could/should be used for.
Right now config space shouldn't propagate out side any driver, so you
can probably just filter it in your generic code, and make it very hard
and obviously wrong for a driver to parse ranges for config space, so
we don't get more usages.
Jason
next prev parent reply other threads:[~2014-04-16 21:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 23:12 [PATCH v5 0/4] APM X-Gene PCIe controller Tanmay Inamdar
2014-03-19 23:12 ` [PATCH v5 1/4] pci: APM X-Gene PCIe controller driver Tanmay Inamdar
2014-03-21 10:15 ` Sunil Kovvuri
2014-03-21 18:23 ` Tanmay Inamdar
2014-03-25 14:05 ` Liviu Dudau
2014-03-25 19:56 ` Bjorn Helgaas
2014-03-25 8:52 ` Phil.Edworthy
2014-03-25 21:52 ` Tanmay Inamdar
2014-03-25 14:02 ` Liviu Dudau
2014-03-25 22:12 ` Tanmay Inamdar
2014-03-26 10:13 ` Liviu Dudau
2014-03-19 23:12 ` [PATCH v5 2/4] arm64: dts: APM X-Gene PCIe device tree nodes Tanmay Inamdar
2014-03-26 14:28 ` Rob Herring
2014-03-26 15:35 ` Liviu Dudau
2014-03-26 16:35 ` Jason Gunthorpe
2014-04-16 17:05 ` Liviu Dudau
2014-04-16 21:21 ` Jason Gunthorpe [this message]
[not found] ` <20140416212104.GA3469-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2014-04-17 0:20 ` Liviu Dudau
2014-04-17 1:24 ` Jason Gunthorpe
2014-04-22 12:49 ` Liviu Dudau
2014-03-19 23:12 ` [PATCH v5 3/4] dt-bindings: pci: xgene pcie device tree bindings Tanmay Inamdar
2014-03-19 23:12 ` [PATCH v5 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver Tanmay Inamdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416212104.GA3469@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=patches@apm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).