From: Andy Gross <agross@codeaurora.org>
To: Stanimir Vabanov <svarbanov@mm-sol.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
devicetree@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH 1/2] dmaengine: qcom_bam_dma: Add v1.3.0 driver support
Date: Fri, 18 Apr 2014 14:41:01 -0500 [thread overview]
Message-ID: <20140418194101.GA12607@qualcomm.com> (raw)
In-Reply-To: <53505D3F.9000108@mm-sol.com>
On Fri, Apr 18, 2014 at 02:01:19AM +0300, Stanimir Vabanov wrote:
<snip>
> >
> > static const struct of_device_id bam_of_match[] = {
> > + { .compatible = "qcom,bam-v1.3.0", },
> > { .compatible = "qcom,bam-v1.4.0", },
>
> you could use the of_device_id::data field to switch between different
> versions.
>
> I mean this:
>
> static const struct of_device_id bam_of_match[] = {
> { .compatible = "qcom,bam-v1.3.0", .data = ®_offs_v1_3 },
> { .compatible = "qcom,bam-v1.4.0", .data = ®_offs_v1_4 },
> }
>
> and during .probe you will get the correct offsets per version. It then
> could be assigned to a variable in bdev.
>
> Then the defines could be:
>
> #define BAM_CTRL(bdev) (bdev->reg_offs->ctrl_offs + 0x00)
>
> I'm not sure how many additional code this will be but it looks clearer.
That's not a bad idea. I'll try this out and see how it looks.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-04-18 19:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 21:45 [PATCH 0/2] dmaengine: qcom_bam_dma: Add support for v1.3.0 Andy Gross
2014-04-16 21:45 ` [PATCH 1/2] dmaengine: qcom_bam_dma: Add v1.3.0 driver support Andy Gross
2014-04-17 23:01 ` Stanimir Vabanov
2014-04-18 19:41 ` Andy Gross [this message]
2014-04-16 21:45 ` [PATCH 2/2] dmaengine: qcom_bam_dma: Add binding for v1.3.0 Andy Gross
2014-08-18 6:23 ` [PATCH 0/2] dmaengine: qcom_bam_dma: Add support " Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418194101.GA12607@qualcomm.com \
--to=agross@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).