From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Sebastian Reichel <sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Cc: Sebastian Reichel <sre-GFxCN5SEZAc@public.gmane.org>,
Marek Belisko <marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>,
Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv2 3/9] mfd: twl4030-madc: Cleanup driver
Date: Sun, 20 Apr 2014 17:54:05 +0200 [thread overview]
Message-ID: <20140420155405.GC16649@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1393970751-18157-4-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Hi!
> Some style fixes in twl4030-madc driver.
>
> Reported-by: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Signed-off-by: Sebastian Reichel <sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
> Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Reviewed-by: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
> @@ -665,10 +660,6 @@ out:
> }
> EXPORT_SYMBOL_GPL(twl4030_madc_conversion);
>
> -/*
> - * Return channel value
> - * Or < 0 on failure.
> - */
> int twl4030_get_madc_conversion(int channel_no)
> {
> struct twl4030_madc_request req;
Maybe I'd put the comment on one line, but it seems useful...?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-04-20 15:54 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 13:17 [PATCH 1/2] mfd: twl4030-madc: Add devicetree support Marek Belisko
2014-02-14 13:17 ` [PATCH 2/2] ARM: dts: twl4030: Add twl4030-madc node Marek Belisko
2014-02-14 13:48 ` [PATCH 1/2] mfd: twl4030-madc: Add devicetree support Lee Jones
2014-02-14 14:53 ` Belisko Marek
[not found] ` <CAAfyv36FH364OPnktx_Qh6sUfwYe7hynqrc3Xs_tY4gPXqQWvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-14 15:28 ` Lee Jones
2014-02-14 17:40 ` Sebastian Reichel
2014-02-14 18:46 ` [RFCv1 1/4] mfd: twl4030-madc: Use managed resources Sebastian Reichel
2014-02-14 18:46 ` [RFCv1 2/4] mfd: twl4030-madc: Add DT support and convert to IIO framework Sebastian Reichel
[not found] ` <1392403586-30540-2-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-15 13:31 ` Belisko Marek
[not found] ` <CAAfyv36yfd0tSe9G2AnX+DzE-gObdRxYfgK+NKT8zwYmqt=QcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-16 9:02 ` Sebastian Reichel
2014-02-14 18:46 ` [RFCv1 3/4] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
2014-02-14 18:46 ` [RFCv1 4/4] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
[not found] ` <1392403586-30540-4-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-22 12:47 ` Jonathan Cameron
[not found] ` <53089C47.5050404-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-02-23 0:35 ` Sebastian Reichel
[not found] ` <20140223003504.GA28154-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org>
2014-02-23 11:02 ` Jonathan Cameron
[not found] ` <5309D536.9020404-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-02-23 22:01 ` Sebastian Reichel
[not found] ` <20140223220140.GA1258-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org>
2014-02-23 22:07 ` [RFCv2 0/5] Convert twl4030-madc to IIO API Sebastian Reichel
2014-02-23 22:07 ` [RFCv2 1/5] mfd: twl4030-madc: Use managed resources Sebastian Reichel
2014-02-23 22:07 ` [RFCv2 2/5] mfd: twl4030-madc: Add DT support and convert to IIO framework Sebastian Reichel
2014-02-23 22:07 ` [RFCv2 3/5] mfd: twl4030-madc: Cleanup driver Sebastian Reichel
2014-02-23 22:07 ` [RFCv2 4/5] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
[not found] ` <1393193271-16717-1-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-23 22:07 ` [RFCv2 5/5] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
2014-02-23 22:15 ` Joe Perches
[not found] ` <1393193271-16717-6-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-24 9:20 ` Peter Meerwald
2014-02-26 0:24 ` [RFCv3 0/7] Convert twl4030-madc to IIO API and add DT support Sebastian Reichel
2014-02-26 0:24 ` [RFCv3 1/7] mfd: twl4030-madc: Use managed resources Sebastian Reichel
2014-02-26 0:24 ` [RFCv3 2/7] mfd: twl4030-madc: Add DT support and convert to IIO framework Sebastian Reichel
[not found] ` <1393374270-20079-3-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-26 9:26 ` Lee Jones
2014-02-26 0:24 ` [RFCv3 3/7] mfd: twl4030-madc: Cleanup driver Sebastian Reichel
[not found] ` <1393374270-20079-4-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-26 8:29 ` Lee Jones
[not found] ` <1393374270-20079-1-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-26 0:24 ` [RFCv3 4/7] mfd: twl-core: Add twl_i2c_read/write_u16 Sebastian Reichel
[not found] ` <1393374270-20079-5-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-26 8:15 ` Lee Jones
2014-02-26 0:24 ` [RFCv3 5/7] mfd: twl4030-madc: Use twl_i2c_read/write_u16 for 16 bit registers Sebastian Reichel
2014-02-26 8:02 ` Lee Jones
2014-02-26 11:42 ` [RFCv3 0/7] Convert twl4030-madc to IIO API and add DT support Belisko Marek
2014-02-26 20:03 ` [RFCv4 " Sebastian Reichel
2014-02-26 20:03 ` [RFCv4 1/7] mfd: twl4030-madc: Use managed resources Sebastian Reichel
2014-02-26 20:03 ` [RFCv4 2/7] mfd: twl4030-madc: Add DT support and convert to IIO framework Sebastian Reichel
[not found] ` <1393444990-28140-3-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-27 8:23 ` Lee Jones
2014-03-01 11:33 ` Jonathan Cameron
2014-02-26 20:03 ` [RFCv4 3/7] mfd: twl4030-madc: Cleanup driver Sebastian Reichel
[not found] ` <1393444990-28140-4-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-27 8:03 ` Lee Jones
2014-03-01 11:41 ` Jonathan Cameron
2014-02-26 20:03 ` [RFCv4 4/7] mfd: twl-core: Add twl_i2c_read/write_u16 Sebastian Reichel
[not found] ` <1393444990-28140-5-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-01 11:48 ` Jonathan Cameron
2014-02-26 20:03 ` [RFCv4 5/7] mfd: twl4030-madc: Use twl_i2c_read/write_u16 for 16 bit registers Sebastian Reichel
[not found] ` <1393444990-28140-6-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-01 11:49 ` Jonathan Cameron
2014-02-26 20:03 ` [RFCv4 6/7] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
[not found] ` <1393444990-28140-7-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-01 11:50 ` Jonathan Cameron
[not found] ` <1393444990-28140-1-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-26 20:03 ` [RFCv4 7/7] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
[not found] ` <1393444990-28140-8-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-01 11:51 ` Jonathan Cameron
2014-03-01 11:52 ` [RFCv4 0/7] Convert twl4030-madc to IIO API and add DT support Jonathan Cameron
[not found] ` <5311CA14.6080009-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-03-01 17:12 ` Sebastian Reichel
2014-03-03 8:00 ` Lee Jones
2014-03-01 19:32 ` [PATCHv1 0/9] " Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 1/9] mfd: twl4030-madc: Use managed resources Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 2/9] mfd: twl4030-madc: Add DT support and convert to IIO framework Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 3/9] mfd: twl4030-madc: Cleanup driver Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 4/9] mfd: twl-core: Add twl_i2c_read/write_u16 Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 5/9] mfd: twl4030-madc: Use twl_i2c_read/write_u16 for 16 bit registers Sebastian Reichel
[not found] ` <1393702365-26429-1-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-01 19:32 ` [PATCHv1 6/9] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
2014-03-04 22:05 ` [PATCHv2 0/9] Convert twl4030-madc to IIO API and add DT support Sebastian Reichel
2014-03-04 22:05 ` [PATCHv2 1/9] mfd: twl4030-madc: Use managed resources Sebastian Reichel
[not found] ` <1393970751-18157-2-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-15 15:19 ` Jonathan Cameron
2014-04-20 15:51 ` Pavel Machek
2014-03-04 22:05 ` [PATCHv2 2/9] mfd: twl4030-madc: Add DT support and convert to IIO framework Sebastian Reichel
[not found] ` <1393970751-18157-3-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-05 1:40 ` Lee Jones
2014-03-15 15:23 ` Jonathan Cameron
2014-04-20 15:52 ` Pavel Machek
2014-03-04 22:05 ` [PATCHv2 3/9] mfd: twl4030-madc: Cleanup driver Sebastian Reichel
[not found] ` <1393970751-18157-4-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-15 15:25 ` Jonathan Cameron
2014-04-20 15:54 ` Pavel Machek [this message]
[not found] ` <1393970751-18157-1-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-04 22:05 ` [PATCHv2 4/9] mfd: twl-core: Add twl_i2c_read/write_u16 Sebastian Reichel
2014-03-04 22:05 ` [PATCHv2 5/9] mfd: twl4030-madc: Use twl_i2c_read/write_u16 for 16 bit registers Sebastian Reichel
2014-03-04 22:05 ` [PATCHv2 6/9] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
[not found] ` <1393970751-18157-7-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-15 15:27 ` Jonathan Cameron
2014-03-04 22:05 ` [PATCHv2 7/9] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
2014-03-04 22:05 ` [PATCHv2 8/9] iio: documentation: Add ABI documentation for *_mean_raw Sebastian Reichel
[not found] ` <1393970751-18157-9-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-15 15:28 ` Jonathan Cameron
2014-03-04 22:05 ` [PATCHv2 9/9] iio: inkern: add iio_read_channel_average_raw Sebastian Reichel
[not found] ` <1393970751-18157-10-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-03-15 15:30 ` Jonathan Cameron
2014-03-05 21:00 ` [PATCHv2 0/9] Convert twl4030-madc to IIO API and add DT support Belisko Marek
2014-03-10 10:43 ` Lee Jones
2014-03-10 11:15 ` Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 7/9] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 8/9] iio: documentation: Add ABI documentation for *_mean_raw Sebastian Reichel
2014-03-01 19:32 ` [PATCHv1 9/9] iio: inkern: add iio_read_channel_average_raw Sebastian Reichel
2014-02-26 0:24 ` [RFCv3 6/7] Documentation: DT: Document twl4030-madc binding Sebastian Reichel
2014-02-26 0:24 ` [RFCv3 7/7] mfd: twl4030-madc: Move driver to drivers/iio/adc Sebastian Reichel
2014-02-24 16:05 ` [RFCv1 4/4] " Lee Jones
[not found] ` <1392403586-30540-1-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2014-02-24 16:04 ` [RFCv1 1/4] mfd: twl4030-madc: Use managed resources Lee Jones
2014-02-15 13:37 ` [PATCH 1/2] mfd: twl4030-madc: Add devicetree support Belisko Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140420155405.GC16649@amd.pavel.ucw.cz \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org \
--cc=sre-GFxCN5SEZAc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).