devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RFC] ARM: dts: am335x: update USB DT references
@ 2014-04-16 11:26 Leigh Brown
  2014-04-22 14:14 ` Benoit Cousson
  0 siblings, 1 reply; 7+ messages in thread
From: Leigh Brown @ 2014-04-16 11:26 UTC (permalink / raw)
  To: Mugunthan V N
  Cc: devicetree, Leigh Brown, Tony Lindgren, Sebastian Andrzej Siewior,
	Felipe Balbi, linux-omap, linux-arm-kernel

In "ARM: dts: am33xx: correcting dt node unit address for usb", the
usb_ctrl_mod and cppi41dma nodes were updated with the correct register
addresses.  However, the dts files that reference these nodes were not
updated, and those devices are no longer being enabled.

This patch corrects the references for the affected dts files.

Signed-off-by: Leigh Brown <leigh@solinno.co.uk>
---
 arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
 arch/arm/boot/dts/am335x-evm.dts          | 4 ++--
 arch/arm/boot/dts/am335x-evmsk.dts        | 4 ++--
 arch/arm/boot/dts/am335x-igep0033.dtsi    | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
index e3f27ec..2e7d932 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -183,7 +183,7 @@
 &usb {
 	status = "okay";
 
-	control@44e10000 {
+	control@44e10620 {
 		status = "okay";
 	};
 
@@ -204,7 +204,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller@07402000  {
+	dma-controller@47402000  {
 		status = "okay";
 	};
 };
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 28ae040..77df10d 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -331,7 +331,7 @@
 &usb {
 	status = "okay";
 
-	control@44e10000 {
+	control@44e10620 {
 		status = "okay";
 	};
 
@@ -352,7 +352,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller@07402000  {
+	dma-controller@47402000  {
 		status = "okay";
 	};
 };
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index ec08f6f..ab23885 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -364,7 +364,7 @@
 &usb {
 	status = "okay";
 
-	control@44e10000 {
+	control@44e10620 {
 		status = "okay";
 	};
 
@@ -385,7 +385,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller@07402000  {
+	dma-controller@47402000  {
 		status = "okay";
 	};
 };
diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi b/arch/arm/boot/dts/am335x-igep0033.dtsi
index 7063311..5942e7d 100644
--- a/arch/arm/boot/dts/am335x-igep0033.dtsi
+++ b/arch/arm/boot/dts/am335x-igep0033.dtsi
@@ -202,7 +202,7 @@
 &usb {
 	status = "okay";
 
-	control@44e10000 {
+	control@44e10620 {
 		status = "okay";
 	};
 
@@ -223,7 +223,7 @@
 		dr_mode = "host";
 	};
 
-	dma-controller@07402000  {
+	dma-controller@47402000  {
 		status = "okay";
 	};
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH RFC] ARM: dts: am335x: update USB DT references
  2014-04-16 11:26 [PATCH RFC] ARM: dts: am335x: update USB DT references Leigh Brown
@ 2014-04-22 14:14 ` Benoit Cousson
  2014-04-23 14:48   ` Tony Lindgren
  0 siblings, 1 reply; 7+ messages in thread
From: Benoit Cousson @ 2014-04-22 14:14 UTC (permalink / raw)
  To: Leigh Brown, Mugunthan V N
  Cc: devicetree, Tony Lindgren, Sebastian Andrzej Siewior,
	Felipe Balbi, linux-omap, linux-arm-kernel

Hi Leigh,

On 16/04/2014 13:26, Leigh Brown wrote:
> In "ARM: dts: am33xx: correcting dt node unit address for usb", the
> usb_ctrl_mod and cppi41dma nodes were updated with the correct register
> addresses.  However, the dts files that reference these nodes were not
> updated, and those devices are no longer being enabled.
>
> This patch corrects the references for the affected dts files.

Thanks for the fix. BTW, why is it a RFC? Do you plan to send an updated 
version?

FYI, even with this fix, the BBB still does not have a working MUSB on 
3.15-rc2. Have you observed that as well?

> Signed-off-by: Leigh Brown <leigh@solinno.co.uk>

If this is a final version, I'll apply it for -rc3.

Thanks,
Benoit


> ---
>   arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
>   arch/arm/boot/dts/am335x-evm.dts          | 4 ++--
>   arch/arm/boot/dts/am335x-evmsk.dts        | 4 ++--
>   arch/arm/boot/dts/am335x-igep0033.dtsi    | 4 ++--
>   4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index e3f27ec..2e7d932 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -183,7 +183,7 @@
>   &usb {
>   	status = "okay";
>
> -	control@44e10000 {
> +	control@44e10620 {
>   		status = "okay";
>   	};
>
> @@ -204,7 +204,7 @@
>   		dr_mode = "host";
>   	};
>
> -	dma-controller@07402000  {
> +	dma-controller@47402000  {
>   		status = "okay";
>   	};
>   };
> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index 28ae040..77df10d 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -331,7 +331,7 @@
>   &usb {
>   	status = "okay";
>
> -	control@44e10000 {
> +	control@44e10620 {
>   		status = "okay";
>   	};
>
> @@ -352,7 +352,7 @@
>   		dr_mode = "host";
>   	};
>
> -	dma-controller@07402000  {
> +	dma-controller@47402000  {
>   		status = "okay";
>   	};
>   };
> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
> index ec08f6f..ab23885 100644
> --- a/arch/arm/boot/dts/am335x-evmsk.dts
> +++ b/arch/arm/boot/dts/am335x-evmsk.dts
> @@ -364,7 +364,7 @@
>   &usb {
>   	status = "okay";
>
> -	control@44e10000 {
> +	control@44e10620 {
>   		status = "okay";
>   	};
>
> @@ -385,7 +385,7 @@
>   		dr_mode = "host";
>   	};
>
> -	dma-controller@07402000  {
> +	dma-controller@47402000  {
>   		status = "okay";
>   	};
>   };
> diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi b/arch/arm/boot/dts/am335x-igep0033.dtsi
> index 7063311..5942e7d 100644
> --- a/arch/arm/boot/dts/am335x-igep0033.dtsi
> +++ b/arch/arm/boot/dts/am335x-igep0033.dtsi
> @@ -202,7 +202,7 @@
>   &usb {
>   	status = "okay";
>
> -	control@44e10000 {
> +	control@44e10620 {
>   		status = "okay";
>   	};
>
> @@ -223,7 +223,7 @@
>   		dr_mode = "host";
>   	};
>
> -	dma-controller@07402000  {
> +	dma-controller@47402000  {
>   		status = "okay";
>   	};
>   };
>


-- 
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RFC] ARM: dts: am335x: update USB DT references
  2014-04-22 14:14 ` Benoit Cousson
@ 2014-04-23 14:48   ` Tony Lindgren
  2014-04-23 15:17     ` Ezequiel Garcia
  2014-04-23 15:35     ` Benoit Cousson
  0 siblings, 2 replies; 7+ messages in thread
From: Tony Lindgren @ 2014-04-23 14:48 UTC (permalink / raw)
  To: Benoit Cousson
  Cc: Leigh Brown, Mugunthan V N, devicetree, Sebastian Andrzej Siewior,
	Felipe Balbi, linux-omap, linux-arm-kernel

* Benoit Cousson <bcousson@baylibre.com> [140422 07:14]:
> Hi Leigh,
> 
> On 16/04/2014 13:26, Leigh Brown wrote:
> >In "ARM: dts: am33xx: correcting dt node unit address for usb", the
> >usb_ctrl_mod and cppi41dma nodes were updated with the correct register
> >addresses.  However, the dts files that reference these nodes were not
> >updated, and those devices are no longer being enabled.
> >
> >This patch corrects the references for the affected dts files.
> 
> Thanks for the fix. BTW, why is it a RFC? Do you plan to send an updated
> version?
> 
> FYI, even with this fix, the BBB still does not have a working MUSB on
> 3.15-rc2. Have you observed that as well?
> 
> >Signed-off-by: Leigh Brown <leigh@solinno.co.uk>
> 
> If this is a final version, I'll apply it for -rc3.

Looks like I already have this in omap-for-v3.15/fixes-v2, sorry
looks like I never replied to this one.

Regards,

Tony 
 
> >---
> >  arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
> >  arch/arm/boot/dts/am335x-evm.dts          | 4 ++--
> >  arch/arm/boot/dts/am335x-evmsk.dts        | 4 ++--
> >  arch/arm/boot/dts/am335x-igep0033.dtsi    | 4 ++--
> >  4 files changed, 8 insertions(+), 8 deletions(-)
> >
> >diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> >index e3f27ec..2e7d932 100644
> >--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> >+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> >@@ -183,7 +183,7 @@
> >  &usb {
> >  	status = "okay";
> >
> >-	control@44e10000 {
> >+	control@44e10620 {
> >  		status = "okay";
> >  	};
> >
> >@@ -204,7 +204,7 @@
> >  		dr_mode = "host";
> >  	};
> >
> >-	dma-controller@07402000  {
> >+	dma-controller@47402000  {
> >  		status = "okay";
> >  	};
> >  };
> >diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> >index 28ae040..77df10d 100644
> >--- a/arch/arm/boot/dts/am335x-evm.dts
> >+++ b/arch/arm/boot/dts/am335x-evm.dts
> >@@ -331,7 +331,7 @@
> >  &usb {
> >  	status = "okay";
> >
> >-	control@44e10000 {
> >+	control@44e10620 {
> >  		status = "okay";
> >  	};
> >
> >@@ -352,7 +352,7 @@
> >  		dr_mode = "host";
> >  	};
> >
> >-	dma-controller@07402000  {
> >+	dma-controller@47402000  {
> >  		status = "okay";
> >  	};
> >  };
> >diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
> >index ec08f6f..ab23885 100644
> >--- a/arch/arm/boot/dts/am335x-evmsk.dts
> >+++ b/arch/arm/boot/dts/am335x-evmsk.dts
> >@@ -364,7 +364,7 @@
> >  &usb {
> >  	status = "okay";
> >
> >-	control@44e10000 {
> >+	control@44e10620 {
> >  		status = "okay";
> >  	};
> >
> >@@ -385,7 +385,7 @@
> >  		dr_mode = "host";
> >  	};
> >
> >-	dma-controller@07402000  {
> >+	dma-controller@47402000  {
> >  		status = "okay";
> >  	};
> >  };
> >diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi b/arch/arm/boot/dts/am335x-igep0033.dtsi
> >index 7063311..5942e7d 100644
> >--- a/arch/arm/boot/dts/am335x-igep0033.dtsi
> >+++ b/arch/arm/boot/dts/am335x-igep0033.dtsi
> >@@ -202,7 +202,7 @@
> >  &usb {
> >  	status = "okay";
> >
> >-	control@44e10000 {
> >+	control@44e10620 {
> >  		status = "okay";
> >  	};
> >
> >@@ -223,7 +223,7 @@
> >  		dr_mode = "host";
> >  	};
> >
> >-	dma-controller@07402000  {
> >+	dma-controller@47402000  {
> >  		status = "okay";
> >  	};
> >  };
> >
> 
> 
> -- 
> Benoît Cousson
> BayLibre
> Embedded Linux Technology Lab
> www.baylibre.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RFC] ARM: dts: am335x: update USB DT references
  2014-04-23 14:48   ` Tony Lindgren
@ 2014-04-23 15:17     ` Ezequiel Garcia
  2014-04-23 15:40       ` Benoit Cousson
  2014-04-23 15:35     ` Benoit Cousson
  1 sibling, 1 reply; 7+ messages in thread
From: Ezequiel Garcia @ 2014-04-23 15:17 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Benoit Cousson, Leigh Brown, Mugunthan V N, devicetree,
	Sebastian Andrzej Siewior, Felipe Balbi, linux-omap,
	linux-arm-kernel

On Apr 23, Tony Lindgren wrote:
> * Benoit Cousson <bcousson@baylibre.com> [140422 07:14]:
> > Hi Leigh,
> > 
> > On 16/04/2014 13:26, Leigh Brown wrote:
> > >In "ARM: dts: am33xx: correcting dt node unit address for usb", the
> > >usb_ctrl_mod and cppi41dma nodes were updated with the correct register
> > >addresses.  However, the dts files that reference these nodes were not
> > >updated, and those devices are no longer being enabled.
> > >
> > >This patch corrects the references for the affected dts files.

Maybe someone can take care of using phandles instead?

This way, the board's dts files would be immune to such .dtsi changes.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RFC] ARM: dts: am335x: update USB DT references
  2014-04-23 14:48   ` Tony Lindgren
  2014-04-23 15:17     ` Ezequiel Garcia
@ 2014-04-23 15:35     ` Benoit Cousson
  1 sibling, 0 replies; 7+ messages in thread
From: Benoit Cousson @ 2014-04-23 15:35 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Leigh Brown, Mugunthan V N, devicetree, Sebastian Andrzej Siewior,
	Felipe Balbi, linux-omap, linux-arm-kernel

Hi Tony,

On 23/04/2014 16:48, Tony Lindgren wrote:
> * Benoit Cousson <bcousson@baylibre.com> [140422 07:14]:
>> Hi Leigh,
>>
>> On 16/04/2014 13:26, Leigh Brown wrote:
>>> In "ARM: dts: am33xx: correcting dt node unit address for usb", the
>>> usb_ctrl_mod and cppi41dma nodes were updated with the correct register
>>> addresses.  However, the dts files that reference these nodes were not
>>> updated, and those devices are no longer being enabled.
>>>
>>> This patch corrects the references for the affected dts files.
>>
>> Thanks for the fix. BTW, why is it a RFC? Do you plan to send an updated
>> version?
>>
>> FYI, even with this fix, the BBB still does not have a working MUSB on
>> 3.15-rc2. Have you observed that as well?
>>
>>> Signed-off-by: Leigh Brown <leigh@solinno.co.uk>
>>
>> If this is a final version, I'll apply it for -rc3.
>
> Looks like I already have this in omap-for-v3.15/fixes-v2, sorry
> looks like I never replied to this one.

:-)

OK, I'll let you handle this one.

Thanks,
Benoit

>
> Regards,
>
> Tony
>
>>> ---
>>>   arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++--
>>>   arch/arm/boot/dts/am335x-evm.dts          | 4 ++--
>>>   arch/arm/boot/dts/am335x-evmsk.dts        | 4 ++--
>>>   arch/arm/boot/dts/am335x-igep0033.dtsi    | 4 ++--
>>>   4 files changed, 8 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> index e3f27ec..2e7d932 100644
>>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
>>> @@ -183,7 +183,7 @@
>>>   &usb {
>>>   	status = "okay";
>>>
>>> -	control@44e10000 {
>>> +	control@44e10620 {
>>>   		status = "okay";
>>>   	};
>>>
>>> @@ -204,7 +204,7 @@
>>>   		dr_mode = "host";
>>>   	};
>>>
>>> -	dma-controller@07402000  {
>>> +	dma-controller@47402000  {
>>>   		status = "okay";
>>>   	};
>>>   };
>>> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
>>> index 28ae040..77df10d 100644
>>> --- a/arch/arm/boot/dts/am335x-evm.dts
>>> +++ b/arch/arm/boot/dts/am335x-evm.dts
>>> @@ -331,7 +331,7 @@
>>>   &usb {
>>>   	status = "okay";
>>>
>>> -	control@44e10000 {
>>> +	control@44e10620 {
>>>   		status = "okay";
>>>   	};
>>>
>>> @@ -352,7 +352,7 @@
>>>   		dr_mode = "host";
>>>   	};
>>>
>>> -	dma-controller@07402000  {
>>> +	dma-controller@47402000  {
>>>   		status = "okay";
>>>   	};
>>>   };
>>> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
>>> index ec08f6f..ab23885 100644
>>> --- a/arch/arm/boot/dts/am335x-evmsk.dts
>>> +++ b/arch/arm/boot/dts/am335x-evmsk.dts
>>> @@ -364,7 +364,7 @@
>>>   &usb {
>>>   	status = "okay";
>>>
>>> -	control@44e10000 {
>>> +	control@44e10620 {
>>>   		status = "okay";
>>>   	};
>>>
>>> @@ -385,7 +385,7 @@
>>>   		dr_mode = "host";
>>>   	};
>>>
>>> -	dma-controller@07402000  {
>>> +	dma-controller@47402000  {
>>>   		status = "okay";
>>>   	};
>>>   };
>>> diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi b/arch/arm/boot/dts/am335x-igep0033.dtsi
>>> index 7063311..5942e7d 100644
>>> --- a/arch/arm/boot/dts/am335x-igep0033.dtsi
>>> +++ b/arch/arm/boot/dts/am335x-igep0033.dtsi
>>> @@ -202,7 +202,7 @@
>>>   &usb {
>>>   	status = "okay";
>>>
>>> -	control@44e10000 {
>>> +	control@44e10620 {
>>>   		status = "okay";
>>>   	};
>>>
>>> @@ -223,7 +223,7 @@
>>>   		dr_mode = "host";
>>>   	};
>>>
>>> -	dma-controller@07402000  {
>>> +	dma-controller@47402000  {
>>>   		status = "okay";
>>>   	};
>>>   };
>>>
>>
>>
>> --
>> Benoît Cousson
>> BayLibre
>> Embedded Linux Technology Lab
>> www.baylibre.com


-- 
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RFC] ARM: dts: am335x: update USB DT references
  2014-04-23 15:17     ` Ezequiel Garcia
@ 2014-04-23 15:40       ` Benoit Cousson
  2014-04-23 15:48         ` Ezequiel Garcia
  0 siblings, 1 reply; 7+ messages in thread
From: Benoit Cousson @ 2014-04-23 15:40 UTC (permalink / raw)
  To: Ezequiel Garcia, Tony Lindgren
  Cc: Leigh Brown, Mugunthan V N, devicetree, Sebastian Andrzej Siewior,
	Felipe Balbi, linux-omap, linux-arm-kernel

Hi Ezequiel,

On 23/04/2014 17:17, Ezequiel Garcia wrote:
> On Apr 23, Tony Lindgren wrote:
>> * Benoit Cousson <bcousson@baylibre.com> [140422 07:14]:
>>> Hi Leigh,
>>>
>>> On 16/04/2014 13:26, Leigh Brown wrote:
>>>> In "ARM: dts: am33xx: correcting dt node unit address for usb", the
>>>> usb_ctrl_mod and cppi41dma nodes were updated with the correct register
>>>> addresses.  However, the dts files that reference these nodes were not
>>>> updated, and those devices are no longer being enabled.
>>>>
>>>> This patch corrects the references for the affected dts files.
>
> Maybe someone can take care of using phandles instead?
>
> This way, the board's dts files would be immune to such .dtsi changes.

Indeed, that will avoid such issues.

Are you volunteer for that cleanup ? :-)

Thanks,
Benoit


-- 
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RFC] ARM: dts: am335x: update USB DT references
  2014-04-23 15:40       ` Benoit Cousson
@ 2014-04-23 15:48         ` Ezequiel Garcia
  0 siblings, 0 replies; 7+ messages in thread
From: Ezequiel Garcia @ 2014-04-23 15:48 UTC (permalink / raw)
  To: Benoit Cousson
  Cc: Tony Lindgren, Leigh Brown, Mugunthan V N, devicetree,
	Sebastian Andrzej Siewior, Felipe Balbi, linux-omap,
	linux-arm-kernel, Guido Martínez

On Apr 23, Benoit Cousson wrote:
> Hi Ezequiel,
> 
> On 23/04/2014 17:17, Ezequiel Garcia wrote:
> >On Apr 23, Tony Lindgren wrote:
> >>* Benoit Cousson <bcousson@baylibre.com> [140422 07:14]:
> >>>Hi Leigh,
> >>>
> >>>On 16/04/2014 13:26, Leigh Brown wrote:
> >>>>In "ARM: dts: am33xx: correcting dt node unit address for usb", the
> >>>>usb_ctrl_mod and cppi41dma nodes were updated with the correct register
> >>>>addresses.  However, the dts files that reference these nodes were not
> >>>>updated, and those devices are no longer being enabled.
> >>>>
> >>>>This patch corrects the references for the affected dts files.
> >
> >Maybe someone can take care of using phandles instead?
> >
> >This way, the board's dts files would be immune to such .dtsi changes.
> 
> Indeed, that will avoid such issues.
> 
> Are you volunteer for that cleanup ? :-)
> 

Sure, I've already done that for my custom dts. It's a simple change.

If someone feels like doing this before I get to send the patches,
be my guest :-)
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-04-23 15:48 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-16 11:26 [PATCH RFC] ARM: dts: am335x: update USB DT references Leigh Brown
2014-04-22 14:14 ` Benoit Cousson
2014-04-23 14:48   ` Tony Lindgren
2014-04-23 15:17     ` Ezequiel Garcia
2014-04-23 15:40       ` Benoit Cousson
2014-04-23 15:48         ` Ezequiel Garcia
2014-04-23 15:35     ` Benoit Cousson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).