From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: "Karicheri, Muralidharan" <m-karicheri2@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"Balbi, Felipe" <balbi@ti.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Randy Dunlap <rdunlap@infradead.org>, Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH] serial: uart: add hw flow control support configuration
Date: Thu, 24 Apr 2014 16:30:27 -0700 [thread overview]
Message-ID: <20140424233027.GA21443@kroah.com> (raw)
In-Reply-To: <20140423152717.7100f604@alan.etchedpixels.co.uk>
On Wed, Apr 23, 2014 at 03:27:17PM +0100, One Thousand Gnomes wrote:
> > >- if (up->capabilities & UART_CAP_AFE && port->fifosize >= 32) {
> > >+ if ((up->capabilities & UART_CAP_AFE && (port->fifosize >= 32)) ||
> > >+ port->flags & UPF_HARD_FLOW) {
> >
> > [Alan] Surely you want brackets on the port->flags & UPF_HARD_FLOW ??
> >
> > The C precedence table shows following order:=
> > -> & ||
> >
> > So flags will be accessed first and then AND-ed with UPF_HARD_FLOW and
> > result will be OR-ed with left side expression value. So no need for bracket IMO.
>
> Yep... agreed.
Perhaps, but please put them there so we all _know_ what it is doing is
correct.
greg k-h
next prev parent reply other threads:[~2014-04-24 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 19:17 [PATCH] serial: uart: add hw flow control support configuration Murali Karicheri
2014-04-12 16:58 ` One Thousand Gnomes
2014-04-23 14:21 ` Karicheri, Muralidharan
2014-04-23 14:27 ` One Thousand Gnomes
2014-04-24 23:30 ` Greg Kroah-Hartman [this message]
2014-04-23 14:31 ` Karicheri, Muralidharan
2014-04-24 23:30 ` Greg Kroah-Hartman
2014-04-29 17:07 ` Karicheri, Muralidharan
2014-04-29 18:37 ` Karicheri, Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424233027.GA21443@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jslaby@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mark.rutland@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).