From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH v2 03/18] usb: host: xhci-plat: Add support for the Armada 38x Date: Fri, 25 Apr 2014 22:25:36 +0200 Message-ID: <20140425222536.430d5c4d@skate> References: <1398434836-18908-1-git-send-email-gregory.clement@free-electrons.com> <1398434836-18908-4-git-send-email-gregory.clement@free-electrons.com> <5392399.GiPjM0CIZ0@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5392399.GiPjM0CIZ0@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Gregory CLEMENT , Mathias Nyman , Greg Kroah-Hartman , Felipe Balbi , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Lior Amsalem , Tawfik Bayouk , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Nadav Haklai , Rob Herring , Ezequiel Garcia , Grant Likely List-Id: devicetree@vger.kernel.org Dear Arnd Bergmann, On Fri, 25 Apr 2014 22:01:51 +0200, Arnd Bergmann wrote: > I think you're doing it the wrong way around: You have a specialized > version of the generic xhci-plat driver. The normal way to handle this > is to have a loadable module that contains all the Armada specific > code and that registers a platform_driver. In the probe() function of > that driver, you can do the platform specific setup and then call > the generic xhci_plat_probe() function, which of course has to > be provided using EXPORT_SYMBOL_GPL. You should have a look at the v1 Gregory sent: it was implementing exactly what you suggest here, but Felipe explicitly requested the patches to be changed like is now proposed in v2. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html