From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board Date: Wed, 30 Apr 2014 11:03:14 -0700 Message-ID: <20140430180314.GA3245@sirena.org.uk> References: <1398243705-31151-1-git-send-email-tushar.behera@linaro.org> <20140424133920.GA12304@sirena.org.uk> <5359E18B.60600@linaro.org> <20140429222915.GU15125@sirena.org.uk> <5360E5E7.8090807@linaro.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Return-path: Content-Disposition: inline In-Reply-To: <5360E5E7.8090807@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org To: Tushar Behera Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org, sbkim73@samsung.com, rdunlap@infradead.org, dianders@chromium.org List-Id: devicetree@vger.kernel.org --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 30, 2014 at 05:30:39PM +0530, Tushar Behera wrote: > XCLKOUT mux register (0x10040a00) is not part of core clock SFR range, > rather it is part of pmu-system-controller node. > One option would be to add a clock provider for XCLKOUT. That would > require me to extend current clock driver to get the > pmu-system-controller phandle which in turn is dependent on the patch to > early initialize syscon driver.[1] > Will it be okay to configure XCLKOUT in snow sound-card driver by taking > the phandle of pmu-system-controller from device tree? The > implementation is provided below. I can't think of any reason why we'd not want to have this visible as a clock? Ideally we don't want to have any ASoC specific clock APIs when we're done, the reason we do at the minute is that the clock API isn't available as standard. --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTYTrZAAoJELSic+t+oim9oUYP/2pJyGSWadsihsAISnlYXZw8 XDUmpFDNf8XQCOn6RyiY3vZdeQtnVkmmuMCIoKYJrLdnddHu/yrN6KQ5nx8TQyME bpomOqs5cJ6BcIQ8AGIaDTqimGZ4kIP6I+H9t3MLOuET2mArmJNJnMcj/TRKAhYL /edSQNcx+vpJYJU3h3MYFYSqQTt6DRBb1IG0CzegJ5IfOdSCFhwr0wut/2m727rn GKwQyPmV7YySyodFF7WEhJweYchEdWPbK7vMGRCfwSH2TSvlGEilIvsgiNvMXZiX H5CWk1KFfMEUdcHz2VxfBXwq7CjvMWjdS4RQBx73JpOyjHOopr9CJgnVXqKakF1I o0Sq62i0HpQk+o/e3BNmUyDsmo99ZDRTVj6LnMDAkZZ5rSfO06qVIQMQ4tHnCplR dlhEyqWkbNwX2Hhd1kftfiwQm9alvao7KhoPmZ1eNF78JO8a+NrG/xV4GG+H9xBU Ajs537yybrZAnPEKo3uLB46MU3G7SF3Mza1a/IJSvDBYl3XbxHb5rGXViiEVlrb7 9euCrxfRf5C2LABWHw697YVljXy4jU5I2Ld17NVWBYlR8GXWU7fJ3T/imoprZWKW l13YzgUEhQ6QU2JJ6eH4SjXMOWql4oVxD7EZuUdrmXfxE7mUiCyxJLU2BB2z/WgX zjdX73g/rxlN1qTn5uXx =2ALA -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s--