From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH v3 06/20] usb: host: xhci-plat: Add support for the Armada 38x Date: Tue, 6 May 2014 14:10:23 +0200 Message-ID: <20140506141023.715b932d@skate> References: <1399335255-589-1-git-send-email-gregory.clement@free-electrons.com> <1399335255-589-7-git-send-email-gregory.clement@free-electrons.com> <1584794.IM1uiSkBdk@amdc1032> <61061197.hLhKsFqJLF@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <61061197.hLhKsFqJLF@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Arnd Bergmann Cc: Lior Amsalem , Andrew Lunn , linux-usb@vger.kernel.org, Jason Cooper , Mathias Nyman , devicetree@vger.kernel.org, Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, Felipe Balbi , Nadav Haklai , Gregory CLEMENT , Rob Herring , Ezequiel Garcia , Grant Likely , Tawfik Bayouk , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org Dear Arnd Bergmann, On Tue, 06 May 2014 13:57:44 +0200, Arnd Bergmann wrote: > > Please limit this driver to mvebu arch and compile testing, i.e. > > > > depends on ARCH_MVEBU || COMPILE_TEST > > I think it actually needs a dependency on MVEBU_MBUS. That's not what we do for any of the other drivers that use the MVEBU_MBUS functions. > You probably need something like > > depends on MVEBU_MBUS=y || (MVEBU_MBUS=m && USB_XHCI=m) MVEBU_MBUS is a bool, so there is no way is can be =m. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com