* [PATCH 2/4] ARM: dts: am335x-evm: use phandles for USB and DMA refs
2014-04-28 13:58 [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs Guido Martínez
@ 2014-04-28 13:58 ` Guido Martínez
2014-05-06 16:16 ` Felipe Balbi
2014-04-28 13:58 ` [PATCH 3/4] ARM: dts: am335x-evmsk: " Guido Martínez
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Guido Martínez @ 2014-04-28 13:58 UTC (permalink / raw)
To: LKML, bcousson, tony
Cc: mark.rutland, devicetree, linux, pawel.moll, ijc+devicetree,
robh+dt, Guido Martínez, Ezequiel García, galak,
linux-omap, linux-arm-kernel
Use phandles instead of unit adresses to reference usb and dma nodes.
This makes the DT more robust and readable.
Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
---
arch/arm/boot/dts/am335x-evm.dts | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 6028217..e802627 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -331,28 +331,28 @@
&usb {
status = "okay";
- control@44e10620 {
+ &usb_ctrl_mod {
status = "okay";
};
- usb-phy@47401300 {
+ &usb0_phy {
status = "okay";
};
- usb-phy@47401b00 {
+ &usb1_phy {
status = "okay";
};
- usb@47401000 {
+ &usb0 {
status = "okay";
};
- usb@47401800 {
+ &usb1 {
status = "okay";
dr_mode = "host";
};
- dma-controller@47402000 {
+ &cppi41dma {
status = "okay";
};
};
--
1.9.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/4] ARM: dts: am335x-evm: use phandles for USB and DMA refs
2014-04-28 13:58 ` [PATCH 2/4] ARM: dts: am335x-evm: " Guido Martínez
@ 2014-05-06 16:16 ` Felipe Balbi
0 siblings, 0 replies; 10+ messages in thread
From: Felipe Balbi @ 2014-05-06 16:16 UTC (permalink / raw)
To: Guido Martínez
Cc: LKML, bcousson, tony, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux, linux-omap, devicetree,
linux-arm-kernel, Ezequiel García
[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]
On Mon, Apr 28, 2014 at 10:58:30AM -0300, Guido Martínez wrote:
> Use phandles instead of unit adresses to reference usb and dma nodes.
> This makes the DT more robust and readable.
>
> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/boot/dts/am335x-evm.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index 6028217..e802627 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -331,28 +331,28 @@
> &usb {
> status = "okay";
>
> - control@44e10620 {
> + &usb_ctrl_mod {
> status = "okay";
> };
>
> - usb-phy@47401300 {
> + &usb0_phy {
> status = "okay";
> };
>
> - usb-phy@47401b00 {
> + &usb1_phy {
> status = "okay";
> };
>
> - usb@47401000 {
> + &usb0 {
> status = "okay";
> };
>
> - usb@47401800 {
> + &usb1 {
> status = "okay";
> dr_mode = "host";
> };
>
> - dma-controller@47402000 {
> + &cppi41dma {
> status = "okay";
> };
> };
> --
> 1.9.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/4] ARM: dts: am335x-evmsk: use phandles for USB and DMA refs
2014-04-28 13:58 [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs Guido Martínez
2014-04-28 13:58 ` [PATCH 2/4] ARM: dts: am335x-evm: " Guido Martínez
@ 2014-04-28 13:58 ` Guido Martínez
2014-05-06 16:16 ` Felipe Balbi
2014-04-28 13:58 ` [PATCH 4/4] ARM: dts: am335x-igep0033: " Guido Martínez
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Guido Martínez @ 2014-04-28 13:58 UTC (permalink / raw)
To: LKML, bcousson, tony
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux,
linux-omap, devicetree, linux-arm-kernel, Ezequiel García,
Guido Martínez
Use phandles instead of unit adresses to reference usb and dma nodes.
This makes the DT more robust and readable.
Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
---
arch/arm/boot/dts/am335x-evmsk.dts | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index ab23885..44b8d75 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -364,28 +364,28 @@
&usb {
status = "okay";
- control@44e10620 {
+ &usb_ctrl_mod {
status = "okay";
};
- usb-phy@47401300 {
+ &usb0_phy {
status = "okay";
};
- usb-phy@47401b00 {
+ &usb1_phy {
status = "okay";
};
- usb@47401000 {
+ &usb0 {
status = "okay";
};
- usb@47401800 {
+ &usb1 {
status = "okay";
dr_mode = "host";
};
- dma-controller@47402000 {
+ &cppi41dma {
status = "okay";
};
};
--
1.9.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 3/4] ARM: dts: am335x-evmsk: use phandles for USB and DMA refs
2014-04-28 13:58 ` [PATCH 3/4] ARM: dts: am335x-evmsk: " Guido Martínez
@ 2014-05-06 16:16 ` Felipe Balbi
0 siblings, 0 replies; 10+ messages in thread
From: Felipe Balbi @ 2014-05-06 16:16 UTC (permalink / raw)
To: Guido Martínez
Cc: LKML, bcousson, tony, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux, linux-omap, devicetree,
linux-arm-kernel, Ezequiel García
[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]
On Mon, Apr 28, 2014 at 10:58:31AM -0300, Guido Martínez wrote:
> Use phandles instead of unit adresses to reference usb and dma nodes.
> This makes the DT more robust and readable.
>
> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/boot/dts/am335x-evmsk.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
> index ab23885..44b8d75 100644
> --- a/arch/arm/boot/dts/am335x-evmsk.dts
> +++ b/arch/arm/boot/dts/am335x-evmsk.dts
> @@ -364,28 +364,28 @@
> &usb {
> status = "okay";
>
> - control@44e10620 {
> + &usb_ctrl_mod {
> status = "okay";
> };
>
> - usb-phy@47401300 {
> + &usb0_phy {
> status = "okay";
> };
>
> - usb-phy@47401b00 {
> + &usb1_phy {
> status = "okay";
> };
>
> - usb@47401000 {
> + &usb0 {
> status = "okay";
> };
>
> - usb@47401800 {
> + &usb1 {
> status = "okay";
> dr_mode = "host";
> };
>
> - dma-controller@47402000 {
> + &cppi41dma {
> status = "okay";
> };
> };
> --
> 1.9.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 4/4] ARM: dts: am335x-igep0033: use phandles for USB and DMA refs
2014-04-28 13:58 [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs Guido Martínez
2014-04-28 13:58 ` [PATCH 2/4] ARM: dts: am335x-evm: " Guido Martínez
2014-04-28 13:58 ` [PATCH 3/4] ARM: dts: am335x-evmsk: " Guido Martínez
@ 2014-04-28 13:58 ` Guido Martínez
2014-05-06 16:17 ` Felipe Balbi
[not found] ` <1398693512-5355-1-git-send-email-guido-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
2014-05-06 16:16 ` Felipe Balbi
4 siblings, 1 reply; 10+ messages in thread
From: Guido Martínez @ 2014-04-28 13:58 UTC (permalink / raw)
To: LKML, bcousson, tony
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux,
linux-omap, devicetree, linux-arm-kernel, Ezequiel García,
Guido Martínez
Use phandles instead of unit adresses to reference usb and dma nodes.
This makes the DT more robust and readable.
Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
---
arch/arm/boot/dts/am335x-igep0033.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi b/arch/arm/boot/dts/am335x-igep0033.dtsi
index 9f22c18..81cf68b 100644
--- a/arch/arm/boot/dts/am335x-igep0033.dtsi
+++ b/arch/arm/boot/dts/am335x-igep0033.dtsi
@@ -201,28 +201,28 @@
&usb {
status = "okay";
- control@44e10620 {
+ &usb_ctrl_mod {
status = "okay";
};
- usb-phy@47401300 {
+ &usb0_phy {
status = "okay";
};
- usb-phy@47401b00 {
+ &usb1_phy {
status = "okay";
};
- usb@47401000 {
+ &usb0 {
status = "okay";
};
- usb@47401800 {
+ &usb1 {
status = "okay";
dr_mode = "host";
};
- dma-controller@47402000 {
+ &cppi41dma {
status = "okay";
};
};
--
1.9.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 4/4] ARM: dts: am335x-igep0033: use phandles for USB and DMA refs
2014-04-28 13:58 ` [PATCH 4/4] ARM: dts: am335x-igep0033: " Guido Martínez
@ 2014-05-06 16:17 ` Felipe Balbi
0 siblings, 0 replies; 10+ messages in thread
From: Felipe Balbi @ 2014-05-06 16:17 UTC (permalink / raw)
To: Guido Martínez
Cc: LKML, bcousson, tony, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux, linux-omap, devicetree,
linux-arm-kernel, Ezequiel García
[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]
On Mon, Apr 28, 2014 at 10:58:32AM -0300, Guido Martínez wrote:
> Use phandles instead of unit adresses to reference usb and dma nodes.
> This makes the DT more robust and readable.
>
> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/boot/dts/am335x-igep0033.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi b/arch/arm/boot/dts/am335x-igep0033.dtsi
> index 9f22c18..81cf68b 100644
> --- a/arch/arm/boot/dts/am335x-igep0033.dtsi
> +++ b/arch/arm/boot/dts/am335x-igep0033.dtsi
> @@ -201,28 +201,28 @@
> &usb {
> status = "okay";
>
> - control@44e10620 {
> + &usb_ctrl_mod {
> status = "okay";
> };
>
> - usb-phy@47401300 {
> + &usb0_phy {
> status = "okay";
> };
>
> - usb-phy@47401b00 {
> + &usb1_phy {
> status = "okay";
> };
>
> - usb@47401000 {
> + &usb0 {
> status = "okay";
> };
>
> - usb@47401800 {
> + &usb1 {
> status = "okay";
> dr_mode = "host";
> };
>
> - dma-controller@47402000 {
> + &cppi41dma {
> status = "okay";
> };
> };
> --
> 1.9.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <1398693512-5355-1-git-send-email-guido-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>]
* Re: [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs
[not found] ` <1398693512-5355-1-git-send-email-guido-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
@ 2014-04-28 14:41 ` George Cherian
[not found] ` <535E689D.7010204-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 10+ messages in thread
From: George Cherian @ 2014-04-28 14:41 UTC (permalink / raw)
To: Guido Martínez, LKML, bcousson-rdvid1DuHRBWk0Htik3J/w,
tony-4v6yS6AI5VpBDgjK7y7TUQ
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Ezequiel García
On 4/28/2014 7:28 PM, Guido Martínez wrote:
> Use phandles instead of unit adresses to reference usb and dma nodes.
> This makes the DT more robust and readable.
The series will give dtb build errors
Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
FATAL ERROR: Unable to parse input tree
Error: arch/arm/boot/dts/am335x-evmsk.dts:367.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-bone.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
Error: arch/arm/boot/dts/am335x-evm.dts:334.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-evmsk.dtb] Error 1
make[1]: *** [arch/arm/boot/dts/am335x-evm.dtb] Error 1
Error: arch/arm/boot/dts/am335x-igep0033.dtsi:204.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-base0033.dtb] Error 1
Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-boneblack.dtb] Error 1
make: *** [dtbs] Error 2
>
> Signed-off-by: Guido Martínez <guido-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
> ---
> arch/arm/boot/dts/am335x-bone-common.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 2e7d932..b95bc9a 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -183,28 +183,28 @@
> &usb {
> status = "okay";
>
> - control@44e10620 {
> + &usb_ctrl_mod {
> status = "okay";
> };
>
> - usb-phy@47401300 {
> + &usb0_phy {
> status = "okay";
> };
>
> - usb-phy@47401b00 {
> + &usb1_phy {
> status = "okay";
> };
>
> - usb@47401000 {
> + &usb0 {
> status = "okay";
> };
>
> - usb@47401800 {
> + &usb1 {
> status = "okay";
> dr_mode = "host";
> };
>
> - dma-controller@47402000 {
> + &cppi41dma {
> status = "okay";
> };
> };
Instead the patch should be
diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi
b/arch/arm/boot/dts/am335x-bone-common.dtsi
index 2e7d932..06be20a 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -182,31 +182,30 @@
&usb {
status = "okay";
+};
+&usb_ctrl_mod {
+ status = "okay";
+};
- control@44e10620 {
- status = "okay";
- };
-
- usb-phy@47401300 {
- status = "okay";
- };
+&usb0_phy {
+ status = "okay";
+};
- usb-phy@47401b00 {
- status = "okay";
- };
+&usb1_phy {
+ status = "okay";
+};
- usb@47401000 {
- status = "okay";
- };
+&usb {
+ status = "okay";
+};
- usb@47401800 {
- status = "okay";
- dr_mode = "host";
- };
+&usb1 {
+ status = "okay";
+ dr_mode = "host";
+};
- dma-controller@47402000 {
- status = "okay";
- };
+&cppi41dma {
+ status = "okay";
};
--
-George
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs
2014-04-28 13:58 [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs Guido Martínez
` (3 preceding siblings ...)
[not found] ` <1398693512-5355-1-git-send-email-guido-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
@ 2014-05-06 16:16 ` Felipe Balbi
4 siblings, 0 replies; 10+ messages in thread
From: Felipe Balbi @ 2014-05-06 16:16 UTC (permalink / raw)
To: Guido Martínez
Cc: mark.rutland, devicetree, linux, pawel.moll, ijc+devicetree, tony,
LKML, robh+dt, Ezequiel García, bcousson, galak, linux-omap,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1447 bytes --]
On Mon, Apr 28, 2014 at 10:58:29AM -0300, Guido Martínez wrote:
> Use phandles instead of unit adresses to reference usb and dma nodes.
> This makes the DT more robust and readable.
>
> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/boot/dts/am335x-bone-common.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 2e7d932..b95bc9a 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -183,28 +183,28 @@
> &usb {
> status = "okay";
>
> - control@44e10620 {
> + &usb_ctrl_mod {
> status = "okay";
> };
>
> - usb-phy@47401300 {
> + &usb0_phy {
> status = "okay";
> };
>
> - usb-phy@47401b00 {
> + &usb1_phy {
> status = "okay";
> };
>
> - usb@47401000 {
> + &usb0 {
> status = "okay";
> };
>
> - usb@47401800 {
> + &usb1 {
> status = "okay";
> dr_mode = "host";
> };
>
> - dma-controller@47402000 {
> + &cppi41dma {
> status = "okay";
> };
> };
> --
> 1.9.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread