From: Lee Jones <lee.jones@linaro.org>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: "Emilio López" <emilio@elopez.com.ar>,
"Mike Turquette" <mturquette@linaro.org>,
"Samuel Ortiz" <sameo@linux.intel.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
Shuge <shuge@allwinnertech.com>,
kevin@allwinnertech.com, "Hans de Goede" <hdegoede@redhat.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dev@linux-sunxi.org
Subject: Re: [PATCH v2 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit
Date: Fri, 9 May 2014 08:12:46 +0100 [thread overview]
Message-ID: <20140509071246.GE5767@lee--X1> (raw)
In-Reply-To: <536BE366.8080907@free-electrons.com>
> >> +static struct platform_driver sun6i_prcm_driver = {
> >> + .driver = {
> >> + .name = "sun6i-prcm",
> >> + .owner = THIS_MODULE,
> >> + .of_match_table = sun6i_prcm_dt_ids,
> >> + },
> >> + .probe = sun6i_prcm_probe,
> > You need a .remove() call-back.
>
> This driver cannot be compiled as module (see the Kconfig definition)
> and the devices are not hotpluggable, as a result a probed device will
> never be removed.
>
> Do you still want me to implement the remove function ?
.remove() also be run on shut down. It's best practice to have one.
> >> +module_platform_driver(sun6i_prcm_driver);
> >> +
> >> +MODULE_AUTHOR("Boris BREZILLON <boris.brezillon@free-electrons.com>");
> >> +MODULE_DESCRIPTION("Allwinner sun6i PRCM driver");
> >> +MODULE_LICENSE("GPL v2");
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-05-09 7:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 17:25 [PATCH v2 0/7] mfd: add basic sun6i A31 PRCM support Boris BREZILLON
[not found] ` <1399483554-8824-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-05-07 17:25 ` [PATCH v2 1/7] reset: sunxi: document sunxi's reset controllers bindings Boris BREZILLON
2014-05-08 3:05 ` Maxime Ripard
2014-05-07 17:25 ` [PATCH v2 2/7] reset: sunxi: allow MFD subdevices probe Boris BREZILLON
[not found] ` <1399483554-8824-3-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-05-08 3:07 ` Maxime Ripard
2014-05-08 20:05 ` Boris BREZILLON
2014-05-07 17:25 ` [PATCH v2 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit Boris BREZILLON
2014-05-08 3:09 ` Maxime Ripard
2014-05-08 11:02 ` Lee Jones
2014-05-08 20:04 ` Boris BREZILLON
[not found] ` <536BE366.8080907-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-05-09 5:05 ` Priit Laes
2014-05-09 7:11 ` [linux-sunxi] " Lee Jones
2014-05-09 7:12 ` Lee Jones [this message]
2014-05-09 7:34 ` Hans de Goede
[not found] ` <536C84F6.2050701-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-05-09 8:08 ` Lee Jones
2014-05-09 8:18 ` Hans de Goede
[not found] ` <536C8F71.5040604-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-05-09 8:28 ` Boris BREZILLON
2014-05-09 8:59 ` Lee Jones
2014-05-07 17:25 ` [PATCH v2 4/7] mfd: sun6i-prcm: document DT bindings Boris BREZILLON
2014-05-07 17:25 ` [PATCH v2 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support Boris BREZILLON
[not found] ` <1399483554-8824-6-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-05-08 3:11 ` Maxime Ripard
2014-05-07 17:25 ` [PATCH v2 6/7] clk: sunxi: document PRCM clock compatible strings Boris BREZILLON
2014-05-07 17:25 ` [PATCH v2 7/7] ARM: sunxi: dt: add PRCM clk and reset controller subdevices Boris BREZILLON
[not found] ` <1399483554-8824-8-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-05-08 3:17 ` Maxime Ripard
2014-05-08 3:40 ` Chen-Yu Tsai
[not found] ` <CAGb2v664vFwezKVp+C1UYdsUktRhrZDxjsyf9L=kwVHGCUV=HA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-08 14:29 ` Maxime Ripard
2014-05-08 20:08 ` Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509071246.GE5767@lee--X1 \
--to=lee.jones@linaro.org \
--cc=boris.brezillon@free-electrons.com \
--cc=dev@linux-sunxi.org \
--cc=devicetree@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=hdegoede@redhat.com \
--cc=kevin@allwinnertech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=sameo@linux.intel.com \
--cc=shuge@allwinnertech.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).