From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
magnus.damm@gmail.com, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: henninger: add QSPI DT support
Date: Tue, 13 May 2014 09:10:24 +0900 [thread overview]
Message-ID: <20140513001024.GC18157@verge.net.au> (raw)
In-Reply-To: <537151DA.8000101@cogentembedded.com>
On Tue, May 13, 2014 at 02:57:30AM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 05/12/2014 02:53 AM, Simon Horman wrote:
>
> >>>Define the Henninger board dependent part of the QSPI device node.
> >>>Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.
>
> >>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >>>---
> >>>This patch is against 'renesas-devel-v3.15-rc3-20140502' tag of Simon Horman's
> >>>'renesas.git' repo and SDHI0/2 DT support patch posted last weekend.
>
> >>> arch/arm/boot/dts/r8a7791-henninger.dts | 38 ++++++++++++++++++++++++++++++++
> >>> 1 file changed, 38 insertions(+)
>
> >>>Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
> >>>===================================================================
> >>>--- renesas.orig/arch/arm/boot/dts/r8a7791-henninger.dts
> >>>+++ renesas/arch/arm/boot/dts/r8a7791-henninger.dts
> >>[...]
> >>>@@ -158,3 +163,36 @@
> >>> cd-gpios = <&gpio6 22 GPIO_ACTIVE_LOW>;
> >>> status = "okay";
> >>> };
> >>>+
> >>>+&qspi {
> >>>+ pinctrl-0 = <&qspi_pins>;
> >>>+ pinctrl-names = "default";
> >>>+
> >>>+ status = "okay";
> >>>+
> >>>+ flash@0 {
> >>>+ #address-cells = <1>;
> >>>+ #size-cells = <1>;
> >>>+ compatible = "spansion,s25fl512s";
> >>>+ reg = <0>;
> >>>+ spi-max-frequency = <30000000>;
> >>>+ spi-tx-bus-width = <4>;
> >>>+ spi-rx-bus-width = <4>;
> >>>+ m25p,fast-read;
> >>>+
> >>>+ partition@0 {
> >>>+ label = "loader_prg";
> >>>+ reg = <0x00000000 0x00040000>;
> >>>+ read-only;
> >>>+ };
> >>>+ partition@40000 {
> >>>+ label = "user_prg";
> >>>+ reg = <0x00040000 0x00400000>;
> >>>+ read-only;
>
> >> Oops, there shouldn't be "read-only" here, I forgot to refresh
> >>the patch as I'm now seeing... too bad it's too late to resend now.
> >>:-(
>
> >Could you send an incremental fix for me to queue up?
>
> Oops, I've rechecked and it should indeed be read-only, so the
> patch was correct. Sorry. :-)
Thanks for double checking.
I think we can safely do nothing for now :-)
prev parent reply other threads:[~2014-05-13 0:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 22:45 [PATCH] ARM: shmobile: henninger: add QSPI DT support Sergei Shtylyov
2014-05-11 0:26 ` Simon Horman
2014-05-11 18:17 ` Sergei Shtylyov
2014-05-11 22:53 ` Simon Horman
2014-05-12 11:53 ` Sergei Shtylyov
2014-05-12 22:57 ` Sergei Shtylyov
2014-05-13 0:10 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513001024.GC18157@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).