From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH v2 3/3] ARM: i.MX1 clk: Add devicetree support Date: Tue, 13 May 2014 19:31:43 +0200 Message-ID: <20140513173143.GU5858@pengutronix.de> References: <1399997116-4313-1-git-send-email-shc_work@mail.ru> <1399998253.839894262@f391.i.mail.ru> <1399999493.354004023@f391.i.mail.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1399999493.354004023-epzXK9EC9shsdVUOrk1QfQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexander Shiyan Cc: Fabio Estevam , Sascha Hauer , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Shawn Guo , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, May 13, 2014 at 08:44:53PM +0400, Alexander Shiyan wrote: > Tue, 13 May 2014 13:28:28 -0300 =D0=BE=D1=82 Fabio Estevam : > > On Tue, May 13, 2014 at 1:24 PM, Alexander Shiyan wrote: > > > Tue, 13 May 2014 13:18:40 -0300 =D0=BE=D1=82 Fabio Estevam : > > >> On Tue, May 13, 2014 at 1:05 PM, Alexander Shiyan wrote: > > >> > > >> > + clk[IMX1_CLK_DUMMY] =3D > > >> > + imx_clk_fixed("dummy", 0); > > >> > + clk[IMX1_CLK_CLK32] =3D > > >> > + imx_obtain_fixed_clock("clk32", fref); > > >> > + clk[IMX1_CLK_CLK16M_EXT] =3D > > >> > + imx_clk_fixed("clk16m_ext", 16000000); > > >> > + clk[IMX1_CLK_CLK16M] =3D > > >> > + imx_clk_gate("clk16m", "clk16m_ext", CCM_CSCR,= 17); > > >> > > >> Why don't you put each entry into a single line instead? > > >> > > >> Even if it gets larger than 80 columns, it would be easier to re= ad. > > > > > > I thought about it, but came to the conclusion that it is better = to observe > > > the kernel rules. > >=20 > > Do you mean checkpatch complaint? > >=20 > > Then try to make checkpatch happy with other clock file such as > > arch/arm/mach-imx/clk-imx6q. > >=20 > > The result will be unreadable :-) >=20 > As another solution we can use macros, something like this: >=20 > #define IMXCLK_MUX(id, name, reg, off, sz, arr) \ > clk[id] =3D imx_clk_mux(name, reg, off, sz, arr, ARRAY_SIZE(arr)) Please don't do that. We have i.MX specific wrapper functions. Wrapping these again with macros doesn't improve the situation. I'm with Fabio here, I would prefer the functions in a single line. Sascha --=20 Pengutronix e.K. | = | Industrial Linux Solutions | http://www.pengutronix.de/= | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 = | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555= 5 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html