From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Christian Gmeiner <christian.gmeiner@gmail.com>
Subject: Re: [PATCHv4 0/5] Add DT support for fixed PHYs
Date: Fri, 16 May 2014 22:46:47 +0200 [thread overview]
Message-ID: <20140516224647.1a76edac@free-electrons.com> (raw)
In-Reply-To: <CAGVrzca7xi4_sGgF0FyFcM0Zo3-mMENP0-aoU=qoV9qshxNzsw@mail.gmail.com>
Dear Florian Fainelli,
On Fri, 16 May 2014 11:27:36 -0700, Florian Fainelli wrote:
> > Here is a fourth version of the patch set that adds a Device Tree
> > binding and the related code to support fixed PHYs. I'm hoping to get
> > this merged in 3.16.
>
> Thanks for being persistent on this and coming back with these
> patches, that is really appreciated.
>
> I gave this patch set a try on a brcmstb system with SYSTEMPORT and my
> latest changes to net/dsa/ to allow for different PHY setups to be
> used with the SoC integrated switch. This switch has a mix of fixed
> and real PHYs. This works like a charm, so long as you consistently
> use the "new" functions, and not the old ones, which is totally
> expected. This is excellent work!
Thanks a lot for your review and testing.
> As we discussed offline, I think we need to progressively get rid of
> of_phy_connect_fixed() to avoid having to debug situations where the
> old 'fixed-link' property used some sparse addressing scheme, which is
> now incompatible with the dynamic address allocation scheme.
Yes, agreed. As we discussed, my plan is to send a followup patch
series to fix the users of the old API to finally remove it. But I'd
like to do this once this series gets accepted and applied.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-05-16 20:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 14:14 [PATCHv4 0/5] Add DT support for fixed PHYs Thomas Petazzoni
2014-05-16 14:14 ` [PATCHv4 1/5] net: phy: decouple PHY id and PHY address in fixed PHY driver Thomas Petazzoni
2014-05-16 18:30 ` Florian Fainelli
2014-05-16 14:14 ` [PATCHv4 2/5] net: phy: extend fixed driver with fixed_phy_register() Thomas Petazzoni
2014-05-16 18:28 ` Florian Fainelli
2015-09-03 19:20 ` Sergei Shtylyov
2015-09-03 19:23 ` Florian Fainelli
2015-09-03 19:35 ` Sergei Shtylyov
2015-09-03 19:37 ` Sergei Shtylyov
2015-09-03 19:38 ` Florian Fainelli
2015-09-03 19:55 ` Sergei Shtylyov
2014-05-16 14:14 ` [PATCHv4 3/5] of: provide a binding for fixed link PHYs Thomas Petazzoni
[not found] ` <1400249647-4643-4-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-05-16 18:29 ` Florian Fainelli
2014-05-16 14:14 ` [PATCHv4 4/5] net: mvneta: add support for fixed links Thomas Petazzoni
2014-05-16 14:14 ` [PATCHv4 5/5] ARM: mvebu: use the fixed-link PHY DT binding for the Armada XP Matrix board Thomas Petazzoni
[not found] ` <1400249647-4643-1-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-05-16 18:27 ` [PATCHv4 0/5] Add DT support for fixed PHYs Florian Fainelli
2014-05-16 20:46 ` Thomas Petazzoni [this message]
2014-05-16 21:20 ` David Miller
2014-05-18 10:18 ` Thomas Petazzoni
2014-05-18 17:21 ` Florian Fainelli
2014-05-18 17:46 ` Thomas Petazzoni
2014-05-18 23:07 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516224647.1a76edac@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=christian.gmeiner@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=f.fainelli@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tawfik@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).