Re: [PATCHv5 1/3] dts: socfpga: Add bindings for Altera SoC SDRAM controller

[Steffen Trumtrar <s.trumtrar@pengutronix.de>]

Hi Thor!

On Mon, May 19, 2014 at 01:36:30PM -0500, Thor Thayer wrote:
> On Fri, May 16, 2014 at 2:53 AM, Steffen Trumtrar
> <s.trumtrar@pengutronix.de> wrote:
> > Hi!
> >
> > On Thu, May 15, 2014 at 11:04:49AM -0500, tthayer@altera.com wrote:
> >> From: Thor Thayer <tthayer@altera.com>
> >>
> >> Addition of the Altera SDRAM controller bindings and device
> >> tree changes to the Altera SoC project.
> >>
> >> v2: Changes to SoC SDRAM EDAC code.
> >>
> >> v3: Implement code suggestions for SDRAM EDAC code.
> >>
> >> v4: Remove syscon from SDRAM controller bindings.
> >>
> >> v5: No Change, bump version for consistency.
> >>
> >> Signed-off-by: Thor Thayer <tthayer@altera.com>
> >> ---
> >>  .../bindings/arm/altera/socfpga-sdram.txt          |   11 +++++++++++
> >>  arch/arm/boot/dts/socfpga.dtsi                     |    5 +++++
> >>  2 files changed, 16 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-sdram.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-sdram.txt b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram.txt
> >> new file mode 100644
> >> index 0000000..8f8746b
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram.txt
> >> @@ -0,0 +1,11 @@
> >> +Altera SOCFPGA SDRAM Controller
> >> +
> >> +Required properties:
> >> +- compatible : "altr,sdr-ctl";
> >> +- reg : Should contain 1 register ranges(address and length)
> >> +
> >> +Example:
> >> +     sdrctl@ffc25000 {
> >> +             compatible = "altr,sdr-ctl";
> >> +             reg = <0xffc25000 0x1000>;
> >> +     };
> >> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> >> index df43702..6ce912e 100644
> >> --- a/arch/arm/boot/dts/socfpga.dtsi
> >> +++ b/arch/arm/boot/dts/socfpga.dtsi
> >> @@ -676,6 +676,11 @@
> >>                       clocks = <&l4_sp_clk>;
> >>               };
> >>
> >> +             sdrctl@ffc25000 {
> >> +                     compatible = "altr,sdr-ctl", "syscon";
> >                                                    ^^^^^^^^^^
> >
> > Get rid of that, too, please.
> 
> Hi Steffan,
> 
> I believe I need to keep the "syscon". The same register (ctrlcfg)
> that has the ECC enable bitfield also includes the DRAM configuration
> bitfields that other drivers will want to access (specifically the
> FPGA bridge needs this information). Since this register will be
> shared between drivers,  syscon seems like the best solution.
> 

Hm, from looking at the documentation of the ctrlcfg I can't really
understand which bits you would need for the FPGA brigde and why.
That all sounds like stuff you would want to set for the specific
RAM you are dealing with on a specific board.
What bridge are you talking about? The SDRAM bridge?

I can see the problem with the ECC enable, though.

Regards,
Steffen

> >                 sdrctl@ffc25000 {
> >                         compatible = "altr,sdr-ctl";
> >                         reg = <0xffc25000 0x1000>;
> >                         ranges;
> >
> >                         edac@ffc2502c {
> >                                 compatible = "altr,sdram-edac";
> >                                 reg = <0xffc2502c 0x50>;
> >                                 interrupts = <0 39 4>;
> >                         };
> >                 };
> >
> > Then we can later add:
> >
> >                         sdr-ports: ports@ffc2507c {
> >                                 #reset-cells = <1>;
> >                                 compatible = "altr,sdr-ports";
> >                                 reg = <0xffc2507c 0x10>;
> >                                 clocks = <&ddr_dqs_clk>;
> >                                 ...
> >                         };

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |