From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine =?iso-8859-1?Q?T=E9nart?= Subject: Re: [PATCH v4 1/7] phy: add a driver for the Berlin SATA PHY Date: Tue, 20 May 2014 16:03:25 +0200 Message-ID: <20140520140325.GA21579@kwain> References: <1400576675-25265-1-git-send-email-antoine.tenart@free-electrons.com> <1400576675-25265-2-git-send-email-antoine.tenart@free-electrons.com> <1821771.zFvTDGF2Ae@amdc1032> <20140520134942.GC9873@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20140520134942.GC9873@lunn.ch> Sender: linux-ide-owner@vger.kernel.org To: Andrew Lunn Cc: Bartlomiej Zolnierkiewicz , Antoine =?iso-8859-1?Q?T=E9nart?= , thomas.petazzoni@free-electrons.com, zmxu@marvell.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, linux-ide@vger.kernel.org, alexandre.belloni@free-electrons.com, jszhang@marvell.com, tj@kernel.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com List-Id: devicetree@vger.kernel.org On Tue, May 20, 2014 at 03:49:42PM +0200, Andrew Lunn wrote: > On Tue, May 20, 2014 at 02:34:20PM +0200, Bartlomiej Zolnierkiewicz w= rote: > > On Tuesday, May 20, 2014 11:04:29 AM Antoine T=E9nart wrote: > > >=20 > > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > > > index 4906c27fa3bd..b31b1986fda4 100644 > > > --- a/drivers/phy/Kconfig > > > +++ b/drivers/phy/Kconfig > > > @@ -15,6 +15,11 @@ config GENERIC_PHY > > > phy users can obtain reference to the PHY. All the users of t= his > > > framework should select this config. > > > =20 > > > +config PHY_BERLIN_SATA > > > + bool > >=20 > > Is there any real reason why this cannot be tristate? >=20 > What we have seen with SATA drivers and phys, is there is link time > breakage if the SATA driver is built in and the phy is modular. >=20 > Maybe this has been fixed now?=20 Using tristate shouldn't be a problem. I compiled without the PHY driver, no link issue. Antoine --=20 Antoine T=E9nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com