From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Antoine Ténart" <antoine.tenart@free-electrons.com>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kishon@ti.com, linux-ide@vger.kernel.org,
alexandre.belloni@free-electrons.com, jszhang@marvell.com,
tj@kernel.org, linux-arm-kernel@lists.infradead.org,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH v4 1/7] phy: add a driver for the Berlin SATA PHY
Date: Tue, 20 May 2014 16:40:03 +0200 [thread overview]
Message-ID: <20140520144003.GD21579@kwain> (raw)
In-Reply-To: <20140520140631.GF9873@lunn.ch>
On Tue, May 20, 2014 at 04:06:31PM +0200, Andrew Lunn wrote:
> > > > > +config PHY_BERLIN_SATA
> > > > > + bool
> > > >
> > > > Is there any real reason why this cannot be tristate?
> > >
> > > What we have seen with SATA drivers and phys, is there is link time
> > > breakage if the SATA driver is built in and the phy is modular.
> > >
> > > Maybe this has been fixed now?
> >
> > Using tristate shouldn't be a problem. I compiled without the PHY
> > driver, no link issue.
>
> The problem i think was when the PHY core and driver was a module and
> SATA built in. Please give that configuration a go.
I tested, it went fine.
This was actually fixed by:
b51fbf9fb0c3 phy-core: Don't allow building phy-core as a module
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-05-20 14:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 9:04 [PATCH v4 0/7] ARM: berlin: add AHCI support Antoine Ténart
2014-05-20 9:04 ` [PATCH v4 1/7] phy: add a driver for the Berlin SATA PHY Antoine Ténart
2014-05-20 9:11 ` Sebastian Hesselbarth
[not found] ` <537B1C35.20107-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-20 9:15 ` Antoine Ténart
2014-05-20 12:34 ` Bartlomiej Zolnierkiewicz
2014-05-20 13:49 ` Andrew Lunn
2014-05-20 14:03 ` Antoine Ténart
2014-05-20 14:06 ` Andrew Lunn
2014-05-20 14:40 ` Antoine Ténart [this message]
2014-05-20 14:06 ` Antoine Ténart
2014-05-20 14:40 ` Antoine Ténart
2014-05-20 9:04 ` [PATCH v4 2/7] Documentation: bindings: add " Antoine Ténart
2014-05-20 9:04 ` [PATCH v4 3/7] ata: libahci: allow to use multiple PHYs Antoine Ténart
2014-05-20 9:04 ` [PATCH v4 4/7] ata: ahci_platform: add the Marvell Berlin AHCI compatible Antoine Ténart
2014-05-20 9:18 ` Sebastian Hesselbarth
2014-05-20 9:23 ` Antoine Ténart
[not found] ` <1400576675-25265-1-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-05-20 9:04 ` [PATCH v4 5/7] Documentation: bindings: document the sub-nodes AHCI bindings Antoine Ténart
2014-05-20 9:04 ` [PATCH v4 6/7] ARM: berlin: add the AHCI node for the BG2Q Antoine Ténart
2014-05-20 9:04 ` [PATCH v4 7/7] ARM: berlin: enable the eSATA interface on the BG2Q DMP Antoine Ténart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520144003.GD21579@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@marvell.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tj@kernel.org \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).