From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/7] mfd: twl4030-power: Fix hang on reboot if sleep configuration was loaded earlier Date: Tue, 20 May 2014 08:07:49 -0700 Message-ID: <20140520150748.GD27830@atomide.com> References: <1400031250-29542-1-git-send-email-tony@atomide.com> <1400031250-29542-2-git-send-email-tony@atomide.com> <20140520150119.GW24991@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140520150119.GW24991@lee--X1> Sender: linux-omap-owner@vger.kernel.org To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Peter Ujfalusi List-Id: devicetree@vger.kernel.org * Lee Jones [140520 08:02]: > On Tue, 13 May 2014, Tony Lindgren wrote: > > > Looks like we can still hit the issue of wrong load order of > > twl4030 configuration. If we have a sleep configuration loaded, > > and do a warm reset, the device can hang while initializing the > > wakeup12 sequence. We do have a warning message about wrong order > > of twl4030 configuration, but in this case it does not help as > > the sleep configuration was loaded during the previous boot and > > the state of twl4030 is maintained throughout the warm reset. > > > > Fix the issue by clearing any existing sleep configuration > > before we load the warm reset configuration. > > > > Cc: Peter Ujfalusi > > Signed-off-by: Tony Lindgren > > --- > > drivers/mfd/twl4030-power.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Can't vouch for the semantics of the patch, but the code looks good. > > Acked-by: Lee Jones > > Can I just apply this, or would you like Peter to review it first? As far as I'm concerned you can go ahead an apply, it's been floating on the list for a while and Peter is probably busy with other things. Regards, Tony