devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Turquette <mturquette@linaro.org>
To: t-kristo@ti.com, tony@atomide.com, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org, balbi@ti.com
Cc: Sourav Poddar <sourav.poddar@ti.com>
Subject: Re: [PATCHv2] arm: dts: am33xx-clock: Fix ehrpwm tbclk data.
Date: Tue, 20 May 2014 08:22:55 -0700	[thread overview]
Message-ID: <20140520152255.9521.63826@quantum> (raw)
In-Reply-To: <1398760460-10539-1-git-send-email-sourav.poddar@ti.com>

Quoting Sourav Poddar (2014-04-29 01:34:20)
> tbclk does not need to be a composite clock, we can simply
> use gate clock for this purpose.
> 
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>

Looks good.

Regards,
Mike

> ---
> v1->v2:
> change compatible string according to mainline.
>  arch/arm/boot/dts/am33xx-clocks.dtsi |   30 ++++++------------------------
>  1 file changed, 6 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am33xx-clocks.dtsi b/arch/arm/boot/dts/am33xx-clocks.dtsi
> index 9ccfe50..712edce 100644
> --- a/arch/arm/boot/dts/am33xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/am33xx-clocks.dtsi
> @@ -96,47 +96,29 @@
>                 clock-div = <1>;
>         };
>  
> -       ehrpwm0_gate_tbclk: ehrpwm0_gate_tbclk {
> +       ehrpwm0_tbclk: ehrpwm0_tbclk@44e10664 {
>                 #clock-cells = <0>;
> -               compatible = "ti,composite-no-wait-gate-clock";
> +               compatible = "ti,gate-clock";
>                 clocks = <&dpll_per_m2_ck>;
>                 ti,bit-shift = <0>;
>                 reg = <0x0664>;
>         };
>  
> -       ehrpwm0_tbclk: ehrpwm0_tbclk {
> -               #clock-cells = <0>;
> -               compatible = "ti,composite-clock";
> -               clocks = <&ehrpwm0_gate_tbclk>;
> -       };
> -
> -       ehrpwm1_gate_tbclk: ehrpwm1_gate_tbclk {
> +       ehrpwm1_tbclk: ehrpwm1_tbclk@44e10664 {
>                 #clock-cells = <0>;
> -               compatible = "ti,composite-no-wait-gate-clock";
> +               compatible = "ti,gate-clock";
>                 clocks = <&dpll_per_m2_ck>;
>                 ti,bit-shift = <1>;
>                 reg = <0x0664>;
>         };
>  
> -       ehrpwm1_tbclk: ehrpwm1_tbclk {
> -               #clock-cells = <0>;
> -               compatible = "ti,composite-clock";
> -               clocks = <&ehrpwm1_gate_tbclk>;
> -       };
> -
> -       ehrpwm2_gate_tbclk: ehrpwm2_gate_tbclk {
> +       ehrpwm2_tbclk: ehrpwm2_tbclk@44e10664 {
>                 #clock-cells = <0>;
> -               compatible = "ti,composite-no-wait-gate-clock";
> +               compatible = "ti,gate-clock";
>                 clocks = <&dpll_per_m2_ck>;
>                 ti,bit-shift = <2>;
>                 reg = <0x0664>;
>         };
> -
> -       ehrpwm2_tbclk: ehrpwm2_tbclk {
> -               #clock-cells = <0>;
> -               compatible = "ti,composite-clock";
> -               clocks = <&ehrpwm2_gate_tbclk>;
> -       };
>  };
>  &prcm_clocks {
>         clk_32768_ck: clk_32768_ck {
> -- 
> 1.7.9.5
> 

      parent reply	other threads:[~2014-05-20 15:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29  8:34 [PATCHv2] arm: dts: am33xx-clock: Fix ehrpwm tbclk data Sourav Poddar
2014-04-29 12:48 ` Tero Kristo
2014-05-19 13:17   ` Tero Kristo
2014-05-20 15:22 ` Mike Turquette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140520152255.9521.63826@quantum \
    --to=mturquette@linaro.org \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sourav.poddar@ti.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).