From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/7] mfd: twl4030-power: Fix hang on reboot if sleep configuration was loaded earlier Date: Tue, 20 May 2014 18:37:05 +0100 Message-ID: <20140520173705.GA1458@lee--X1> References: <1400031250-29542-1-git-send-email-tony@atomide.com> <1400031250-29542-2-git-send-email-tony@atomide.com> <20140520150119.GW24991@lee--X1> <20140520150748.GD27830@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20140520150748.GD27830@atomide.com> Sender: linux-omap-owner@vger.kernel.org To: Tony Lindgren Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Peter Ujfalusi List-Id: devicetree@vger.kernel.org > > > Looks like we can still hit the issue of wrong load order of > > > twl4030 configuration. If we have a sleep configuration loaded, > > > and do a warm reset, the device can hang while initializing the > > > wakeup12 sequence. We do have a warning message about wrong order > > > of twl4030 configuration, but in this case it does not help as > > > the sleep configuration was loaded during the previous boot and > > > the state of twl4030 is maintained throughout the warm reset. > > >=20 > > > Fix the issue by clearing any existing sleep configuration > > > before we load the warm reset configuration. > > >=20 > > > Cc: Peter Ujfalusi > > > Signed-off-by: Tony Lindgren > > > --- > > > drivers/mfd/twl4030-power.c | 6 ++++++ > > > 1 file changed, 6 insertions(+) > >=20 > > Can't vouch for the semantics of the patch, but the code looks good= =2E > >=20 > > Acked-by: Lee Jones > >=20 > > Can I just apply this, or would you like Peter to review it first? >=20 > As far as I'm concerned you can go ahead an apply, it's been > floating on the list for a while and Peter is probably busy > with other things. No problem. Just a couple of things for you to look at in the other patches, then we can go ahead and apply for v3.16. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html