Re: [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp

Tomi Valkeinen
2014-05-21T12:44:54Z

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

On 14/05/14 00:32, Tony Lindgren wrote:

> +&dss {
> + status = "ok";
> + vdds_dsi-supply = <&vpll2>;
> + port {
> + dpi_out: endpoint {
> + remote-endpoint = <&lcd_in>;
> + data-lines = <18>;
> + };
> + };
> +};

I just noticed the vdds_dsi-supply there. While the driver currently
uses that if available, I think it should be removed, and done the same
way Florian did with his overo patches:

/* Needed to power the DPI pins */
&vpll2 {
regulator-always-on;
};

That supply is not DSS's supply, but it's used to power up the pins. If
the pins were used as GPIOs, that power should be enabled.

Tomi

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]