devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Shubhrajyoti Datta" <omaplinuxkernel@gmail.com>,
	"Carlos Chinea" <cch.devel@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Kumar Gala" <galak@codeaurora.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>,
	"Ивайло Димитров" <freemangordon@abv.bg>,
	"Joni Lapilainen" <joni.lapilainen@gmail.com>,
	"Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Pavel Machek" <pavel@ucw.cz>
Subject: Re: [PATCHv5 09/10] DTS: ARM: OMAP3-N900: Add SSI support
Date: Wed, 21 May 2014 14:09:56 -0700	[thread overview]
Message-ID: <20140521210956.GA14520@atomide.com> (raw)
In-Reply-To: <20140521200928.GA27602@earth.universe>

* Sebastian Reichel <sre@kernel.org> [140521 13:10]:
> Hi,
> 
> On Wed, May 21, 2014 at 11:43:19AM -0700, Tony Lindgren wrote:
> > > > Just noticed that this patch seems to somehow break idle
> > > > modes on n900, so dropping both dts changes for now.
> > > > 
> > > > Basically the n900 debug LEDs won't ever go off with
> > > > these two dts patches enabled, even without the modem
> > > > drivers loaded. I did not dig deeper, but it's probably
> > > > something related to hwmod using this data for some
> > > > settings.
> > > 
> > > Is hwmod data interpreted at all without the DT entries?
> > 
> > Yes for autoidling unused devices. We parse that with
> > omap_device_build_from_dt().
> 
> That function seems to parse DT stuff. What I meant was
> not without the *driver*, but without the *DT entry*.
> 
> I think the hwmod entries are completly ignored until there
> is a DT device?

Yes for device tree based booting. They get initialized
based on the ti,hwmods property. Posted a suggested fix,
you've probably seen it by now :)

Tony

  reply	other threads:[~2014-05-21 21:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-10 16:37 [PATCHv5 00/10] OMAP SSI driver / N900 modem support Sebastian Reichel
2014-05-10 16:37 ` [PATCHv5 01/10] HSI: method to unregister clients from an hsi port Sebastian Reichel
2014-05-10 16:37 ` [PATCHv5 02/10] HSI: Add channel resource support to HSI clients Sebastian Reichel
2014-05-10 16:37 ` [PATCHv5 03/10] HSI: export method to (un)register clients Sebastian Reichel
2014-05-10 16:37 ` [PATCHv5 04/10] HSI: Add common DT binding for HSI client devices Sebastian Reichel
2014-05-10 16:37 ` [PATCHv5 05/10] HSI: Introduce OMAP SSI driver Sebastian Reichel
2014-05-10 16:37 ` [PATCHv5 06/10] Documentation: DT: omap-ssi binding documentation Sebastian Reichel
2014-05-10 16:37 ` [PATCHv5 07/10] HSI: Introduce driver for SSI Protocol Sebastian Reichel
2014-05-10 16:37 ` [PATCHv5 08/10] HSI: Introduce Nokia N900 modem driver Sebastian Reichel
2014-05-10 16:37 ` [PATCHv5 09/10] DTS: ARM: OMAP3-N900: Add SSI support Sebastian Reichel
2014-05-14 21:55   ` Tony Lindgren
2014-05-20  0:35     ` Tony Lindgren
2014-05-21 18:25       ` Sebastian Reichel
2014-05-21 18:43         ` Tony Lindgren
2014-05-21 19:45           ` Tony Lindgren
2014-05-21 21:50             ` Sebastian Reichel
2014-05-21 22:08               ` Tony Lindgren
2014-05-22  0:05                 ` Sebastian Reichel
     [not found]                   ` <20140522000558.GC29118-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org>
2014-05-27 20:35                     ` Tony Lindgren
2014-05-27 20:47                       ` Sebastian Reichel
     [not found]           ` <20140521184319.GL17417-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-05-21 20:09             ` Sebastian Reichel
2014-05-21 21:09               ` Tony Lindgren [this message]
2014-05-10 16:37 ` [PATCHv5 10/10] DTS: ARM: OMAP3-N900: Add modem support Sebastian Reichel
2014-05-14 21:55   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140521210956.GA14520@atomide.com \
    --to=tony@atomide.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=cch.devel@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=freemangordon@abv.bg \
    --cc=galak@codeaurora.org \
    --cc=joni.lapilainen@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=omaplinuxkernel@gmail.com \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).