From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCHv5 09/10] DTS: ARM: OMAP3-N900: Add SSI support Date: Wed, 21 May 2014 15:08:07 -0700 Message-ID: <20140521220807.GB14520@atomide.com> References: <1399739870-13526-1-git-send-email-sre@kernel.org> <1399739870-13526-10-git-send-email-sre@kernel.org> <20140514215503.GM27426@atomide.com> <20140520003538.GD15793@atomide.com> <20140521182513.GA26285@earth.universe> <20140521184319.GL17417@atomide.com> <20140521194527.GM17417@atomide.com> <20140521215055.GA26362@earth.universe> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140521215055.GA26362@earth.universe> Sender: linux-kernel-owner@vger.kernel.org To: Sebastian Reichel Cc: Linus Walleij , Shubhrajyoti Datta , Carlos Chinea , Rob Herring , Pawel Moll , Mark Rutland , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Pali =?utf-8?B?Um9ow6Fy?= , =?utf-8?B?0JjQstCw0LnQu9C+INCU0LjQvNC40YLRgNC+0LI=?= , Joni Lapilainen , Aaro Koskinen , Pavel Machek , Paul Walmsley List-Id: devicetree@vger.kernel.org * Sebastian Reichel [140521 14:51]: > On Wed, May 21, 2014 at 12:45:28PM -0700, Tony Lindgren wrote: > > Right. The only documentation of the SSI module is existing > code sent by Carlos / included in the maemo kernel. That's probably better than any documentation though :) > > > It's probably something with the sysc or idlemodes that > > > keeps things from idling. Maybe wrong address? Or wrong > > > flags? I'm pretty sure it was the first .dts patch out of > > > these two as the second one alone did not apply. > > > > Hmm yeah below is probably how it should be, does this > > work for you? With this fix applied and your ssi dts > > patches n900 keeps hitting off-idle for me. > > I can confirm, that the N900 hits idle states when the DT > patch and the hwmod patch is applied. I have not actually > tested if it also works without your hwmod patch. > > There are still problems with the idle state if the driver is > actually loaded (and I see 100% runtime pm usage in powertop), > but that can be fixed later. > > Feel free to add Tested-by/Acked-By to the hwmod patch. OK thanks for testing. I'll apply your dts changes as soon as I have an ack from Paul on the hwmod changes. Probably best to queue them together to avoid PM breaking. Regards, Tony