Re: [PATCH RESEND 1/2] irqchip: Add generic gic-v1/gic-v2 compat strings.

[Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>]

On Wed, May 21, 2014 at 10:27:33PM +0100, Rob Herring wrote:
> On Wed, May 21, 2014 at 8:48 AM, Nikolay Borisov
> <Nikolay.Borisov-5wv7dgnIgG8@public.gmane.org> wrote:
> > The current set of GIC compatible strings only contains specific
> > implementations (e.g. arm,cortex-a9-gic) rather than revisions of the
> > standard (e.g. arm,gic-v2), so each new implementation must either claim
> > to be an extension of an existing implementation or have a new string
> > added to the driver. This may be problematic when workarounds are
> > required for bugs in particular implementations, as said workaround may
> > end up targeting a wider set of implementations than intended.
> >
> > To prevent these issues, this patch adds compatible strings for the
> > revisions of the GIC spec which all GIC implementations should be able
> > to claim conformance to in addition to any particular implementation
> > specific string, e.g.
> 
> This just encourages not having specific properties which then also
> prevents being able to add work-arounds later. SOCs using the a9 or
> a15 string ONLY that are not an a9 or a15 are wrong. That's what we
> should fix. Adding more generic strings is not going to help that. Do
> you have a specific work-around you need to implement?

AFAIK, we don't have a specific workaround required anywhere that these
strings would help with. It's just that generic GIC strings had been
brought up repeatedly with no particular conclusion.

If we simply ensure that new DTS that feature a GIC have
implementation-specific strings in addition to those we already support
(e.g. "arm,cortex-a9-gic"), then I'm fine with that.

> Given that the GIC specs are obviously meaningless since we now have
> GICv2 with 16 core support as well as the special exynos gics, I'm not
> inclined to accept this.

Arguably neither are "true" GICv2, but your point stands.

Cheers,
Mark.

> 
> Rob
> 
> > compatible = "$VENDOR,specific-gic-variant", "arm,gic-v2";
> >
> > Signed-off-by: Nikolay Borisov <Nikolay.Borisov-5wv7dgnIgG8@public.gmane.org>
> > Acked-by: Mark Rutland <Mark.Rutland-5wv7dgnIgG8@public.gmane.org>
> > ---
> >  drivers/irqchip/irq-gic.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> > index 57d165e..89e9b05 100644
> > --- a/drivers/irqchip/irq-gic.c
> > +++ b/drivers/irqchip/irq-gic.c
> > @@ -1073,6 +1073,8 @@ gic_of_init(struct device_node *node, struct device_node *parent)
> >  }
> >  IRQCHIP_DECLARE(cortex_a15_gic, "arm,cortex-a15-gic", gic_of_init);
> >  IRQCHIP_DECLARE(cortex_a9_gic, "arm,cortex-a9-gic", gic_of_init);
> > +IRQCHIP_DECLARE(gic_v1, "arm,gic-v1", gic_of_init);
> > +IRQCHIP_DECLARE(gic_v2, "arm,gic-v2", gic_of_init);
> >  IRQCHIP_DECLARE(msm_8660_qgic, "qcom,msm-8660-qgic", gic_of_init);
> >  IRQCHIP_DECLARE(msm_qgic2, "qcom,msm-qgic2", gic_of_init);
> >
> > --
> > 1.8.1.5
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html