devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 1/2] ARM: tegra: Add Tegra124 HDA support
@ 2014-05-20 20:37 Dylan Reid
       [not found] ` <CAEUnVG7+=1ko8NL1Z3ovSpGveUADUidy4sBhU_dTUe1zbe-bMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Dylan Reid @ 2014-05-20 20:37 UTC (permalink / raw)
  To: Stephen Warren
  Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Thierry Reding

On Tue, May 20, 2014 at 11:31 AM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
> On 05/20/2014 12:24 PM, Stephen Warren wrote:
>> On 05/19/2014 08:35 PM, Dylan Reid wrote:
>>> Add a device node for the HDA controller found on Tegra124.
>>
>>> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
>>
>>> +    hda@0,70030000 {
>>> +            compatible = "nvidia,tegra124-hda", "nvidia,tegra30-hda";
>>> +            reg = <0x0 0x70030000 0x0 0x10000>;
>>> +            interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
>>> +            clocks = <&tegra_car TEGRA124_CLK_HDA>,
>>> +                     <&tegra_car TEGRA124_CLK_HDA2HDMI>,
>>> +                     <&tegra_car TEGRA124_CLK_HDA2CODEC_2X>;
>>> +            clock-names = "hda", "hda2hdmi", "hdacodec_2x";
>>
>> I think that should be "hda2codec_2x". Same for the reset-names property
>> below. This fix also needs to be propagated into the DT binding
>> documentation.
>
> Even after fixing that, I can't play audio on Venice2:
>
> root@localhost:~# speaker-test -Dhw:0,3 -c 2
>
> speaker-test 1.0.27.1
>
> Playback device is hw:0,3
> Stream parameters are 48000Hz, S16_LE, 2 channels
> Using 16 octaves of pink noise
> Rate set to 48000Hz (requested 48000Hz)
> Buffer size range from 64 to 16384
> Period size range from 32 to 8192
> Using max buffer size 16384
> Periods = 4
> was set period_size = 4096
> was set buffer_size = 16384
>  0 - Front Left
> Write error: -32,Broken pipe
> Write error: -32,Broken pipe
> Write error: -32,Broken pipe
> ^C 1 - Front Right
> Time per period = 1.799791
>

Thanks for checking Stephen.  I'll fix the reset name.

This is the state of the tree I used when I tested on Venice2 just now:
* ae57dbf - (HEAD) ARM: tegra: venice2 - Enable HDA (2 minutes ago)
* 6224524 - ARM: tegra: Add Tegra124 HDA support (2 minutes ago)
* 468ca57 - ALSA: hda - Add driver for Tegra SoC HDA (2 minutes ago)
* 928099e - ALSA: hda/hdmi - Add Nvidia Tegra124 HDMI support (2 minutes ago)
* 701eac4 - clk: tegra124: Enable hda to hdmi clocks (3 minutes ago)
* 6b6ba7b - (next-20140520, linux-next/master) Add linux-next specific
files for 20140520 (11 hours ago)

My speaker-test output is similar to yours, minus the errors, and I
hear noise from the attached monitor.

I tried with the reset name fixed to hda2codec_2x as well and it still
works for me.

Were you testing on one of your public trees?  I couldn't get your
github tree to boot.

Dylan

^ permalink raw reply	[flat|nested] 23+ messages in thread
* [PATCH 1/2] ARM: tegra: Add Tegra124 HDA support
@ 2014-05-20  2:35 Dylan Reid
       [not found] ` <1400553346-23238-1-git-send-email-dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Dylan Reid @ 2014-05-20  2:35 UTC (permalink / raw)
  To: linux-tegra-u79uwXL29TY76Z2rM5mHXA
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, swarren-3lzwWm7+Weoh9ZMKESR00Q,
	thierry.reding-Re5JQEeQqe8AvxtiuMwx3w, Dylan Reid

Add a device node for the HDA controller found on Tegra124.

Signed-off-by: Dylan Reid <dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
---
 arch/arm/boot/dts/tegra124.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
index 6e6bc4e..7890641 100644
--- a/arch/arm/boot/dts/tegra124.dtsi
+++ b/arch/arm/boot/dts/tegra124.dtsi
@@ -449,6 +449,21 @@
 		clock-names = "pclk", "clk32k_in";
 	};
 
+	hda@0,70030000 {
+		compatible = "nvidia,tegra124-hda", "nvidia,tegra30-hda";
+		reg = <0x0 0x70030000 0x0 0x10000>;
+		interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&tegra_car TEGRA124_CLK_HDA>,
+		         <&tegra_car TEGRA124_CLK_HDA2HDMI>,
+			 <&tegra_car TEGRA124_CLK_HDA2CODEC_2X>;
+		clock-names = "hda", "hda2hdmi", "hdacodec_2x";
+		resets = <&tegra_car 125>, /* hda */
+			 <&tegra_car 128>, /* hda2hdmi */
+			 <&tegra_car 111>; /* hda2codec_2x */
+		reset-names = "hda", "hda2hdmi", "hdacodec_2x";
+		status = "disabled";
+	};
+
 	sdhci@0,700b0000 {
 		compatible = "nvidia,tegra124-sdhci";
 		reg = <0x0 0x700b0000 0x0 0x200>;
-- 
1.8.1.3.605.g02339dd

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2014-06-16 19:10 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-20 20:37 [PATCH 1/2] ARM: tegra: Add Tegra124 HDA support Dylan Reid
     [not found] ` <CAEUnVG7+=1ko8NL1Z3ovSpGveUADUidy4sBhU_dTUe1zbe-bMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-20 21:55   ` Stephen Warren
     [not found]     ` <537BCF39.6050909-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-20 23:28       ` Dylan Reid
     [not found]         ` <CAEUnVG7CRWx5Y3RsgPzrHgYRGAx=bS4WY=w1xBUw0Ukt0DTdUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-20 23:42           ` Stephen Warren
2014-05-21 20:55           ` Thierry Reding
2014-05-21 21:10             ` Dylan Reid
     [not found]               ` <CAEUnVG7tDjw_6wHc=FN0KsOKsSS1u8H8SzYdxt9VCwUsARRTeQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-22  9:50                 ` Thierry Reding
2014-05-22 17:48                   ` Dylan Reid
     [not found]                     ` <CAEUnVG5pNMzDoXGso+UiAWPpD0hNPhBPyGr8KfV587AuU70QPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-22 17:54                       ` Stephen Warren
     [not found]                         ` <537E39D9.2000304-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-22 18:05                           ` Dylan Reid
     [not found]                             ` <CAEUnVG4UettOj0xDy+f6qEhUbhNs=u-wgyCf_Prsd2JpnmFfLw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-23  3:55                               ` Dylan Reid
2014-05-23 19:05                                 ` Stephen Warren
     [not found]                                   ` <537F9BEB.5020102-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-23 20:34                                     ` Dylan Reid
     [not found]                                       ` <CAEUnVG63BCgpGuo+qcYkvpnVSSguBy9xwSC_AoZqCt1RgBqm7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-31  1:45                                         ` Dylan Reid
     [not found]                                           ` <CAEUnVG52fJhd9213fdydoUW11N0yZ31T2MZ2BPmd5Q2xkZ8XeQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-04 17:32                                             ` Stephen Warren
     [not found]                                               ` <538F5848.1050803-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-04 17:51                                                 ` Dylan Reid
     [not found]                                               ` <CAEUnVG7bbcPjRcGxn_GAJ7rKJy4g_5veEsRnU 2yCDVWFY3ncUQ@mail.gmail.com>
     [not found]                                                 ` <CAEUnVG7bbcPjRcGxn_GAJ7rKJy4g_5veEsRnU2yCDVWFY3ncUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-04 19:04                                                   ` Stephen Warren
     [not found]                                                     ` <538F6DA5.9040608-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-04 20:43                                                       ` Thierry Reding
2014-06-04 17:13                                         ` Stephen Warren
  -- strict thread matches above, loose matches on Subject: below --
2014-05-20  2:35 Dylan Reid
     [not found] ` <1400553346-23238-1-git-send-email-dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-05-20 18:24   ` Stephen Warren
     [not found]     ` <537B9DE3.5020807-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-20 18:31       ` Stephen Warren
2014-06-16 19:10   ` Stephen Warren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).