From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v2 2/2] ARM: shmobile: r8a7779 dtsi: Update unit-addresses for clocks
Date: Mon, 26 May 2014 09:44:19 +0900 [thread overview]
Message-ID: <20140526004419.GC31096@verge.net.au> (raw)
In-Reply-To: <11119685.9RVVTTLT6z@avalon>
On Fri, May 23, 2014 at 11:36:51AM +0200, Laurent Pinchart wrote:
> Hi Geert,
>
> Thank you for the patch.
>
> On Friday 23 May 2014 09:46:20 Geert Uytterhoeven wrote:
> > - Correct the unit-address for the "cpg_clocks" node,
> > - Add missing unit-addresses for the "mstp*_clks" nodes,
> > - Rename "cpg_clocks" and "mstp*_clks" nodes to the more generic
> > "clocks".
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks, I will queue this up.
> > ---
> > v2:
> > - Spun-off from "ARM: shmobile: r8a7779 dtsi: Correct #address-cells/
> > #size-cells for clocks".
> > - Removed "0x" prefix from cpg_clocks unit-address,
> > - Renamed cpg_clocks and mstp*_clks nodes to the more generic "clocks".
> >
> > arch/arm/boot/dts/r8a7779.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi
> > index 395a611e2b5a..61d08f42456c 100644
> > --- a/arch/arm/boot/dts/r8a7779.dtsi
> > +++ b/arch/arm/boot/dts/r8a7779.dtsi
> > @@ -298,7 +298,7 @@
> > };
> >
> > /* Special CPG clocks */
> > - cpg_clocks: cpg_clocks@0xe6150000 {
> > + cpg_clocks: clocks@ffc80000 {
> > compatible = "renesas,r8a7779-cpg-clocks";
> > reg = <0xffc80000 0x30>;
> > clocks = <&extal_clk>;
> > @@ -342,7 +342,7 @@
> > };
> >
> > /* Gate clocks */
> > - mstp0_clks: mstp0_clks {
> > + mstp0_clks: clocks@ffc80030 {
> > compatible = "renesas,r8a7779-mstp-clocks",
> > "renesas,cpg-mstp-clocks";
> > reg = <0xffc80030 4>;
> > @@ -379,7 +379,7 @@
> > "scif1", "scif0", "i2c3", "i2c2", "i2c1",
> > "i2c0";
> > };
> > - mstp1_clks: mstp1_clks {
> > + mstp1_clks: clocks@ffc80034 {
> > compatible = "renesas,r8a7779-mstp-clocks",
> > "renesas,cpg-mstp-clocks";
> > reg = <0xffc80034 4>, <0xffc80044 4>;
> > @@ -408,7 +408,7 @@
> > "ether", "sata",
> > "pcie", "vin3";
> > };
> > - mstp3_clks: mstp3_clks {
> > + mstp3_clks: clocks@ffc8003c {
> > compatible = "renesas,r8a7779-mstp-clocks",
> > "renesas,cpg-mstp-clocks";
> > reg = <0xffc8003c 4>;
>
> --
> Regards,
>
> Laurent Pinchart
>
prev parent reply other threads:[~2014-05-26 0:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 7:46 [PATCH v2 0/2] ARM: shmobile: r8a7779/marzen CCF DT updates Geert Uytterhoeven
2014-05-23 7:46 ` [PATCH v2 1/2] ARM: shmobile: r8a7779 dtsi: Correct #address-cells/#size-cells for clocks Geert Uytterhoeven
2014-05-23 9:36 ` Laurent Pinchart
2014-05-26 0:47 ` Simon Horman
2014-05-23 7:46 ` [PATCH v2 2/2] ARM: shmobile: r8a7779 dtsi: Update unit-addresses " Geert Uytterhoeven
2014-05-23 9:36 ` Laurent Pinchart
2014-05-26 0:44 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526004419.GC31096@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).