From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
kishon@ti.com, Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH v4] phy: Renesas R-Car Gen2 PHY driver
Date: Mon, 26 May 2014 18:00:34 +0900 [thread overview]
Message-ID: <20140526090031.GA6155@verge.net.au> (raw)
In-Reply-To: <CAMuHMdUP37MdiZEYZjZ8Gj_h_wojcm7RvmRKxKP2v9g7WqBb3A@mail.gmail.com>
On Mon, May 26, 2014 at 10:04:52AM +0200, Geert Uytterhoeven wrote:
> Hi Simon, Rob,
>
> On Mon, May 26, 2014 at 9:48 AM, Simon Horman <horms@verge.net.au> wrote:
> >> > +Required properties:
> >> > +- compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC.
> >> > + "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC.
> >>
> >> As this is a new driver, I think you should switch to the recommended
> >> vendor/soc/device ordering, which is also supported by checkpatch (incl.
> >> wildcard matching!), i.e. "renesas,r8a7790-usb-phy" etc.
> >
> > A while ago we were asked to consolidate our drivers around a consistent
> > scheme. At the time the <vendor>,<device>-<version> scheme, where version =
>
> (after talking around at ELC) It's my understanding this was a silly mistake.
That is a shame as we switched around the binding for at least one driver
> > SoC for most Renesas parts, was agreed to be acceptable and we have
> > (hopefully) consistently been using that ever since.
>
> We did for everything except for clock drivers, sound, and thermal.
>
> > So unless there has been a policy change I would prefer to keep using this
> > scheme (i.e. leave the bindings above as-is). And update checkpatch if that
> > is appropriate.
>
> Rob, can we have the official policy documented in
> Documentation/devicetree/bindings?
Of course if there is a policy I'm have no objections to following it for
new drivers.
next prev parent reply other threads:[~2014-05-26 9:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 22:06 [PATCH v4] phy: Renesas R-Car Gen2 PHY driver Sergei Shtylyov
2014-05-26 7:28 ` Geert Uytterhoeven
2014-05-26 7:48 ` Simon Horman
2014-05-26 8:04 ` Geert Uytterhoeven
2014-05-26 9:00 ` Simon Horman [this message]
2014-05-27 9:29 ` Yoshihiro Shimoda
2014-05-27 19:38 ` Sergei Shtylyov
2014-05-28 1:12 ` Yoshihiro Shimoda
2014-06-04 11:40 ` Kishon Vijay Abraham I
2014-06-04 21:54 ` Sergei Shtylyov
2014-06-09 11:43 ` Laurent Pinchart
2014-06-10 10:43 ` Kishon Vijay Abraham I
2014-06-25 22:16 ` Sergei Shtylyov
2014-07-01 13:11 ` Kishon Vijay Abraham I
2014-07-04 20:53 ` Sergei Shtylyov
2014-07-08 12:20 ` Kishon Vijay Abraham I
2014-07-08 21:27 ` Sergei Shtylyov
2014-06-09 11:44 ` Laurent Pinchart
2014-06-09 12:34 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526090031.GA6155@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).