From: Borislav Petkov <bp@alien8.de>
To: tthayer@altera.com
Cc: robherring2@gmail.com, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, linux@arm.linux.org.uk, dinguyen@altera.com,
dougthompson@xmission.com, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tthayer.linux@gmail.com
Subject: Re: [PATCHv5 3/3] edac: altera: Add EDAC support for Altera SoC SDRAM Controller
Date: Mon, 26 May 2014 11:57:30 +0200 [thread overview]
Message-ID: <20140526095730.GC25732@pd.tnic> (raw)
In-Reply-To: <1400169891-29546-4-git-send-email-tthayer@altera.com>
On Thu, May 15, 2014 at 11:04:51AM -0500, tthayer@altera.com wrote:
> From: Thor Thayer <tthayer@altera.com>
>
> v2: Use the SDRAM controller registers to calculate memory size
> instead of the Device Tree. Update To & Cc list. Add maintainer
> information.
>
> v3: EDAC driver cleanup based on comments from Mailing list.
>
> v4: Panic on DBE. Add macro around inject-error reads to prevent
> them from being optimized out. Remove of_match_ptr since this
> will always use Device Tree.
>
> v5: Addition of printk to trigger function to ensure read vars
> are not optimized out.
Yeah, you could turn those vX: messages into a real commit message -
much better than none at all :-)
Other than that, the edac bits look ok. I'll wait out until you guys've
sorted the devicetree issues so ping me when it is ready to pick up.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-05-26 9:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 16:04 Add EDAC support for Altera SoC SDRAM Controller tthayer
2014-05-15 16:04 ` [PATCHv5 1/3] dts: socfpga: Add bindings for Altera SoC SDRAM controller tthayer
2014-05-16 7:53 ` Steffen Trumtrar
2014-05-19 18:36 ` Thor Thayer
2014-05-19 19:12 ` Steffen Trumtrar
2014-05-19 19:37 ` Thor Thayer
2014-05-20 14:31 ` Alan Tull
2014-05-20 14:44 ` Steffen Trumtrar
2014-05-21 15:38 ` Thor Thayer
2014-05-27 7:11 ` Steffen Trumtrar
2014-05-27 18:00 ` Thor Thayer
2014-05-27 19:51 ` Steffen Trumtrar
2014-05-27 19:12 ` Alan Tull
2014-05-27 19:42 ` Steffen Trumtrar
[not found] ` <20140527194228.GB13172-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-05-27 20:57 ` Alan Tull
2014-05-28 7:01 ` Steffen Trumtrar
2014-05-28 14:38 ` Alan Tull
2014-05-15 16:04 ` [PATCHv5 2/3] dts: socfpga: Add bindings for Altera SoC SDRAM EDAC tthayer
2014-05-15 16:04 ` [PATCHv5 3/3] edac: altera: Add EDAC support for Altera SoC SDRAM Controller tthayer
2014-05-26 9:57 ` Borislav Petkov [this message]
[not found] ` <20140526095730.GC25732-fF5Pk5pvG8Y@public.gmane.org>
2014-05-27 17:58 ` Thor Thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526095730.GC25732@pd.tnic \
--to=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=dougthompson@xmission.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robherring2@gmail.com \
--cc=tthayer.linux@gmail.com \
--cc=tthayer@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).