From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCHv5 3/3] edac: altera: Add EDAC support for Altera SoC SDRAM Controller Date: Mon, 26 May 2014 11:57:30 +0200 Message-ID: <20140526095730.GC25732@pd.tnic> References: <1400169891-29546-1-git-send-email-tthayer@altera.com> <1400169891-29546-4-git-send-email-tthayer@altera.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1400169891-29546-4-git-send-email-tthayer@altera.com> Sender: linux-doc-owner@vger.kernel.org To: tthayer@altera.com Cc: robherring2@gmail.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rob@landley.net, linux@arm.linux.org.uk, dinguyen@altera.com, dougthompson@xmission.com, grant.likely@linaro.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tthayer.linux@gmail.com List-Id: devicetree@vger.kernel.org On Thu, May 15, 2014 at 11:04:51AM -0500, tthayer@altera.com wrote: > From: Thor Thayer > > v2: Use the SDRAM controller registers to calculate memory size > instead of the Device Tree. Update To & Cc list. Add maintainer > information. > > v3: EDAC driver cleanup based on comments from Mailing list. > > v4: Panic on DBE. Add macro around inject-error reads to prevent > them from being optimized out. Remove of_match_ptr since this > will always use Device Tree. > > v5: Addition of printk to trigger function to ensure read vars > are not optimized out. Yeah, you could turn those vX: messages into a real commit message - much better than none at all :-) Other than that, the edac bits look ok. I'll wait out until you guys've sorted the devicetree issues so ping me when it is ready to pick up. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --